1742928 - Test xpcom/tests/unit/test_localfile.js/test_file_creation_time is disabled and failing

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Jari Jalkanen]

Test xpcom/tests/unit/test_localfile.js/test_file_creation_time is disabled.

When enabled, line 178, Assert.ok(creationTime === file.lastModifiedTime); is triggered, it turns out there is a 10 ms delay which is more than (now - creationTime) before the assert (tested on Windows.)

Before fixing the test, it should be investigated whether the test is correct or if there is something unexpected with the implementation.

Additionally, if the test is correct, would be better to use Assert.equals(creationTime, file.lastModifiedTime) to get more information on failure.

Comment 1

[Mark Banner (:standard8)]

Bug 1660841 introduced this, so adding a "regressed by" as that seems most appropraite, also cc'ing Barret who implemented it.

Note that bug 1762749 is enabling this test for mac-only as it passes there.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1660841

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:barret, since you are the author of the regressor, bug 1660841, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1742928 - Re-enable test_localfile.js test_file_creation_time on Windows r?nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86f9dbdce9c9
Re-enable test_localfile.js test_file_creation_time on Windows r=nika

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/86f9dbdce9c9

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:barret, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Barret Rennie [:barret] (they/them)]

Comment on attachment 9271323 [details]
Bug 1742928 - Re-enable test_localfile.js test_file_creation_time on Windows r?nika

Beta/Release Uplift Approval Request

• User impact if declined: None, this is test-only
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky because this is test-only
• String changes made/needed:

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9271323 [details]
Bug 1742928 - Re-enable test_localfile.js test_file_creation_time on Windows r?nika

Declining the uplift due to a dependency on a test suite that caused this not to graft cleanly in beta.