1743082 - Update dialog focusing steps to only apply focus fixup rule in the modal dialog case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Tim Nguyen :ntim]

See https://bugs.webkit.org/show_bug.cgi?id=233514, tests will be added there.

https://github.com/whatwg/html/commit/08b4033db249ea0c63fd35f4e8fa06e85ec20a6f

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743082 - Only clear focus for modal dialog. r=smaug,sefeng

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743082 - While at it, fix inert-node-is-uneditable.html and inert-inlines.html. r=smaug,ntim,sefeng

Failed in Chrome and Firefox with:

marionette_driver.errors.InvalidArgumentException: Expected 'x' ([object Number] 187.5) to be an Integer

Because of fractional widths. Round to deal with it.

Depends on D134964

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743082 - Enable inert attribute on dialog tests to make dialog-focusing-steps-inert.html pass. r=sefeng,smaug

Depends on D134965

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66c51665d7bc
Only clear focus for modal dialog. r=sefeng
https://hg.mozilla.org/integration/autoland/rev/d22ac03072b5
While at it, fix inert-node-is-uneditable.html and inert-inlines.html. r=sefeng
https://hg.mozilla.org/integration/autoland/rev/5d0bf84ee0ea
Enable inert attribute on dialog tests to make dialog-focusing-steps-inert.html pass. r=sefeng,smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32231 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/66c51665d7bc
https://hg.mozilla.org/mozilla-central/rev/d22ac03072b5
https://hg.mozilla.org/mozilla-central/rev/5d0bf84ee0ea

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot