1743236 - Crash in [@ mozilla::dom::ClientSource::SetController]

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

70 content crashes from 3 different installations (both Windows and macOS). All had the Keepa.com - Amazon price tracker extension installed and reported crash url either belongs to amazon or keepa.com.

Crash report: https://crash-stats.mozilla.org/report/index/b6086180-40eb-4126-b1dc-de09f0211127

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(ClientMatchPrincipalInfo(mClientInfo.PrincipalInfo(), aServiceWorker.PrincipalInfo()))

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::ClientSource::SetController dom/clients/manager/ClientSource.cpp:378
1 xul.dll mozilla::dom::ClientSource::InheritController dom/clients/manager/ClientSource.cpp:483
2 xul.dll mozilla::dom::`anonymous namespace'::ScriptExecutorRunnable::WorkerRun dom/workers/ScriptLoader.cpp:2155
3 xul.dll mozilla::dom::WorkerRunnable::Run dom/workers/WorkerRunnable.cpp:378
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1177
5 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:467
6 xul.dll mozilla::dom::WorkerPrivate::RunCurrentSyncLoop dom/workers/WorkerPrivate.cpp:4078
7 xul.dll mozilla::dom::`anonymous namespace'::LoadAllScripts dom/workers/ScriptLoader.cpp:2358
8 xul.dll mozilla::dom::workerinternals::LoadMainScript dom/workers/ScriptLoader.cpp:2471
9 xul.dll mozilla::dom::`anonymous namespace'::CompileScriptRunnable::WorkerRun dom/workers/WorkerPrivate.cpp:371

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Set it as blocker for 96.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1743236 - Part 1: Add StoragePrincipalHelper::ShouldUsePartitionPrincipalForServiceWorker() for WorkerPrivate. r?dimi

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1743236 - Part 2: Use Partitioned Principal when creating clientSource in WorkerPrivate. r?dimi

We should use the parititoned principal when creating clientSource in
WorkerPrivate if the workerPrivate is in third-party context.

Depends on D132369

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1743236 - Part 3: Add a test. r?dimi

This patch adds a test to ensure that a dedicated worker can be created
in a page which is controlled by a servcie worker.

Depends on D132370

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbf250e00ca9
Part 1: Add StoragePrincipalHelper::ShouldUsePartitionPrincipalForServiceWorker() for WorkerPrivate. r=dimi
https://hg.mozilla.org/integration/autoland/rev/f8b6146213d6
Part 2: Use Partitioned Principal when creating clientSource in WorkerPrivate. r=dimi,edenchuang
https://hg.mozilla.org/integration/autoland/rev/dfd4214ae0b8
Part 3: Add a test. r=dimi

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bbf250e00ca9
https://hg.mozilla.org/mozilla-central/rev/f8b6146213d6
https://hg.mozilla.org/mozilla-central/rev/dfd4214ae0b8