1743310 - Paint Flashing doesn't work.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

It's only used by some WebRender fallback code nowadays, so we should probably remove it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743310 - Remove paint flashing support from DevTools. r=nchevobbe

It doesn't do anything useful except on a niche WebRender fallback code-path,
so it's confusing.

Depends on D132301

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743310 - Remove paint flahing support from the layout debugger. r=#layout-reviewers

Doesn't do anything particularly useful nowadays, see above.

Depends on D132311

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743310 - Remove paint flashing. r=#gfx-reviewers

It's only meaningfully read in two places:

• WebRender fallback code.
• Some widget DEBUG-only code, which on Linux is ifdef'd and on Windows does
  some rather sketchy things like sleeping for 30ms

So I think it should be ok to remove, since WR fallback has its own flashing
pref as well, IIUC.

Depends on D132312

Comment 4

[Julian Descottes [:jdescottes]]

FWIW this was discussed in Bug 1612922

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a4585f33439
Remove paint flashing support from DevTools. r=nchevobbe,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/a7aacdcf5479
Remove paint flahing support from the layout debugger. r=hiro
https://hg.mozilla.org/integration/autoland/rev/ec679650594b
Remove paint flashing. r=gfx-reviewers,lsalzman

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0a4585f33439
https://hg.mozilla.org/mozilla-central/rev/a7aacdcf5479
https://hg.mozilla.org/mozilla-central/rev/ec679650594b