Closed Bug 1743310 Opened 3 years ago Closed 3 years ago

Paint Flashing doesn't work.

Categories

(DevTools :: General, defect)

defect

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

It's only used by some WebRender fallback code nowadays, so we should probably remove it.

It doesn't do anything useful except on a niche WebRender fallback code-path,
so it's confusing.

Depends on D132301

Doesn't do anything particularly useful nowadays, see above.

Depends on D132311

It's only meaningfully read in two places:

  • WebRender fallback code.
  • Some widget DEBUG-only code, which on Linux is ifdef'd and on Windows does
    some rather sketchy things like sleeping for 30ms

So I think it should be ok to remove, since WR fallback has its own flashing
pref as well, IIUC.

Depends on D132312

FWIW this was discussed in Bug 1612922

Blocks: 1612922
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a4585f33439
Remove paint flashing support from DevTools. r=nchevobbe,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/a7aacdcf5479
Remove paint flahing support from the layout debugger. r=hiro
https://hg.mozilla.org/integration/autoland/rev/ec679650594b
Remove paint flashing. r=gfx-reviewers,lsalzman
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: