1743531 - [wpt-sync] Sync PR 31788 - SVG Text NG: Fix a crash by <use> with display:contents and text-decoration

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31788 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31788
Details from upstream follow.

Kent Tamura <[e-mail]> wrote:

SVG Text NG: Fix a crash by <use> with display:contents and text-decoration

crrev.com/925670 was not enough for SVG \<use> because it has a different
code path to propagate the \<use> style to a referred tree. See
SVGElement::CustomStyleForLayoutObject().

This CL resolve the issue by not calling ApplyTextDecorations() for
display:contents, and revert the C++ part of crrev.com/925670.

Bug: 1252619, 1253243, 1273800
Change-Id: Iddee8ba2f2bb68d601bc0dbc55207267b8cb55cf
Reviewed-on: https://chromium-review.googlesource.com/3308292
WPT-Export-Revision: 535ec42bef6d19c2e1c726b43e8194fed87af8ac

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=056b83929b858eb7e4f563e2d180ffecaf3f3e8a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL : 1

Chrome

CRASH: 1

Safari

FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-text-decor/text-decoration-propagation-display-contents.html: FAIL (Chrome: CRASH, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8da51fe72834
[wpt PR 31788] - SVG Text NG: Fix a crash by <use> with display:contents and text-decoration, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8da51fe72834