1743612 - Support AddSlot IC stubs for objects with an addProperty hook

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

For now it's hard to get rid of the add-property hook on DOM objects, but we can still optimize this better with ICs by using a VM function.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1743612 part 1 - Add testing function and jit-test for JSClass addProperty hook. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1743612 part 2 - Make AutoCallVM work with ICs without an output register. r?iain!

SetProp/SetElem ICs don't have an output register, resulting in assertion failures
when using AutoCallVM in the next patch.

Depends on D132489

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1743612 part 3 - Support AddSlot IC stubs for objects with an addProperty hook. r?iain!

If the object has an addProperty hook, we call a VM function where we add the
data property and invoke the hook. This still isn't super efficient, but it
eliminates a source of IC failures and helps identify this case in profiles.

Depends on D132490

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1743612 part 4 - Add transpiler support for AddSlotAndCallAddPropHook. r?iain!

Depends on D132491

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9179e377a085
part 1 - Add testing function and jit-test for JSClass addProperty hook. r=iain
https://hg.mozilla.org/integration/autoland/rev/ea09314bae4b
part 2 - Make AutoCallVM work with ICs without an output register. r=iain
https://hg.mozilla.org/integration/autoland/rev/7fe6d2297eb5
part 3 - Support AddSlot IC stubs for objects with an addProperty hook. r=iain
https://hg.mozilla.org/integration/autoland/rev/a9b155370ae7
part 4 - Add transpiler support for AddSlotAndCallAddPropHook. r=iain

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9179e377a085
https://hg.mozilla.org/mozilla-central/rev/ea09314bae4b
https://hg.mozilla.org/mozilla-central/rev/7fe6d2297eb5
https://hg.mozilla.org/mozilla-central/rev/a9b155370ae7