Closed Bug 1743621 Opened 4 years ago Closed 4 years ago

Permanent /webdriver/tests/bidi/log_entry_added/args.py | test_primitive_types[undefined] - setup error: webdriver.error.SessionNotCreatedException: session not created (Requested bidi session, ... when Gecko 96 merges to Beta on 2021-12-06

Categories

(Remote Protocol :: WebDriver BiDi, defect)

defect

Tracking

(firefox-esr91 unaffected, firefox94 unaffected, firefox95 unaffected, firefox96+ verified)

VERIFIED FIXED
96 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox94 --- unaffected
firefox95 --- unaffected
firefox96 + verified

People

(Reporter: aryx, Assigned: aryx)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 external file)

TEST-UNEXPECTED-ERROR | /webdriver/tests/bidi/log_entry_added/args.py | test_primitive_types[undefined] - setup error: webdriver.error.SessionNotCreatedException: session not created (Requested bidi session, but webSocketUrl capability not found)
...

Bug 1693839 didn't move the disabling added in bug 1742580.

Edit: Wait, bug 1693839 got merged now.

Not sure that we understand. Bug 1693839 has been fixed a while ago. And there was bug 1731548 recently which moved the file args.py to console_args.py. But with that patch we also moved the appropriate ini file.

https://hg.mozilla.org/mozilla-central/rev/63cb32ec323baa4489768e0c1d2a8da48cb5d37a

So it's not clear what actually breaks here when a current mozilla-central commit is used for beta uplift.

Flags: needinfo?(aryx.bugmail)

Actually there was an upstream merge conflict for web-platform-tests which needed a fix. As it looks like this got messed up and the recent wpt downstream sync renamed this file back to args.py.

As such the meta ini file is correct, but the test name needs to be updated.

Flags: needinfo?(aryx.bugmail)

Hm, why is searchfox not showing the args.py file?
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/log_entry_added

It's actually outdated and the new and required file is console_args.py. James, how best can we fix upstream so that it is in sync again?

Flags: needinfo?(james)

I think if you update m-c to the state you want the upstream sync will either fail and I can fix it or will be a noop. So just patch m-c to be correct and I can handle the rest (and apologies for the confusion here, I guess if we are reapplying a sync that got changes upstream, and that created a file that has later been removed, we end up recreating the original file).

Flags: needinfo?(james)
Attachment #9253060 - Attachment description: Bug 1743621 - rename console_args.py.ini to args.py.ini in line with test file rename. r=whimboo → Bug 1743621 - remove duplicated args.py file to args.py. r=whimboo
Attachment #9253060 - Attachment description: Bug 1743621 - remove duplicated args.py file to args.py. r=whimboo → Bug 1743621 - remove duplicated args.py file. r=whimboo
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/02d4cb250a5c remove duplicated args.py file. r=whimboo,webdriver-reviewers
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31797 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: