1743656 - Form data not restored correctly

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Jan Alexander Steffens [:heftig]]

STR:

1. Have Fission enabled
2. Open https://c.eev.ee/doom-text-generator/
3. Ctrl+Click the Reload button to clone the tab

In the new tab, the text generator's canvas has a black background instead of a transparent one.

Also reproduces when the tab is closed (Ctrl+W) and restored (Ctrl+Shift+T).

mozregression --launch 2021-11-30 -a https://c.eev.ee/doom-text-generator/ --pref fission.autostart:true

Last good revision: d7e2a6ed23ff5d6915476b8c5d692c93b401100c
First bad revision: c48e578a03e969579cac8380ecd69287a447cca2
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d7e2a6ed23ff5d6915476b8c5d692c93b401100c&tochange=c48e578a03e969579cac8380ecd69287a447cca2

Regressed by bug 1572084.

First encountered while investigating bug 1712969.

Comment 1

[Jan Alexander Steffens [:heftig]]

Now I notice that without bug 1572084 the opened tabs don't have any restored data at all (the text is different), so I guess this was a problem of the Fission session store before and just exposed with that bug?

When I close a session (which had Fission enabled) with an unbugged tab and a bugged tab and then open that session with Fission disabled, the bugged tab is still bugged and the unbugged tab is still unbugged. Cloning either tab also clones the (un)bugged status.

If I instead restore that session with Fission enabled, both tabs are bugged. So it seems this is a problem of restore and not store?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1572084

Comment 3

[Jan Alexander Steffens [:heftig]]

Well, the black background is from the "Background color" checkbox at the bottom of the page being checked when it shouldn't be. I completely overlooked that.

With JavaScript disabled the text doesn't work but the form is cloned correctly. I wonder if this is some kind of race between an event (load?) and the session restore.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.