1743734 - ANGLE reports driver version and date even in sanitized RENDERER string

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

This happened in the newest ANGLE update, and is the exact opposite of what we're trying to do with RENDERER now!

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1743734 - Strip d3d driver version from ANGLE RENDERER strings.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ddcad24243a
Strip d3d driver version from ANGLE RENDERER strings. r=gfx-reviewers,lsalzman

Comment 3

[Cristian Tuns]

Backed out for causing gtest failures on Logging.h

• Backout link
• Push with failures
• Failure Log
• Failure log 2
• Failure line: Assertion failure: [GFX1]: Failed to parse ANGLE renderer: ANGLE (Radeon RX Vega Direct3D11 vs_5_0 ps_5_0), at /builds/worker/workspace/obj-build/dist/include/mozilla/gfx/Logging.h:751
• Failure line 2: TEST-UNEXPECTED-FAIL | SanitizeRenderer.TestAngleVega | Expected equality of these values:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4db83082181
Strip d3d driver version from ANGLE RENDERER strings. r=gfx-reviewers,lsalzman

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on SanitizeRenderer.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/e9849da87985087ece7a8468f22297824fa5144f

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=b4db83082181bdc5ac1e7a84a28e09b0f5380973

• failure log: https://treeherder.mozilla.org/logviewer?job_id=360745451&repo=autoland&lineNumber=9003

[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -  In file included from Unified_cpp_dom_canvas0.cpp:128:
[task 2021-12-10T03:41:25.367Z] 03:41:25    ERROR -  /builds/worker/checkouts/gecko/dom/canvas/SanitizeRenderer.cpp:135:5: error: non-void lambda does not return a value in all control paths [-Werror,-Wreturn-type]
[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -      });
[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -      ^
[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -  1 error generated.
[task 2021-12-10T03:41:25.367Z] 03:41:25    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:662: Unified_cpp_dom_canvas0.o] Error 1
[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/canvas'
[task 2021-12-10T03:41:25.367Z] 03:41:25     INFO -  gmake[4]: *** Waiting for unfinished jobs....

Comment 6

[Natalia Csoregi [:nataliaCs]]

Also failing: TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_renderer_strings.html | [ignore if not on CI] getParameter(RENDERER) -> ANGLE (NVIDIA, GeForce 8800 GTX Direct3D11 vs_5_0 ps_5_0) not known-valid!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae702cad9bd4
Strip d3d driver version from ANGLE RENDERER strings. r=gfx-reviewers,lsalzman

Comment 8

[Marian-Vasile Laza]

Backed out changeset ae702cad9bd4 (Bug 1743734) for causing mochitest failures on test_renderer_strings.html.
Backout link
Push with failures
Failure Log

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1743734 - Add stronger tests for SanitizeRenderer.

In particular expectations for (unmasked,masked) renderer on CI, and add
gtests for the renderer strings we know we'll see on CI.
This way we can run ./mach gtest SanitizeRenderer* locally and be sure
this test won't fall apart on CI's various renderers.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/795007fcea32
Strip d3d driver version from ANGLE RENDERER strings. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/28a6eeb405aa
Add stronger tests for SanitizeRenderer. r=gfx-reviewers,lsalzman

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/795007fcea32
https://hg.mozilla.org/mozilla-central/rev/28a6eeb405aa