1743959 - Refactor around mScrollPort and TryLayout in scroll frame implementation

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

These patches are written when I investigate the scrollbar implementation for bug 1715112. All the patches are refactors, and shouldn't change the behavior.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1743959 Part 1 - Make mScrollPort private, and add a getter and a setter for it.

This patch ports the mScrollPort refactor Boris wrote in
https://phabricator.services.mozilla.com/D129100 with my tweaks.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1743959 Part 2 - Simplify the computation regarding the space occupied by scrollbars in TryLayout.

This patch is inspired by ScrollFrameHelper::GetActualScrollbarSizes() that
uses a nsMargin to represent the space occupied by scrollbar.

In bug 1715112, TryLayout is going to consider the space occupied by the
scrollbar gutter. Hence the variable name with gutter in it just to avoid change
the variable name again.

Depends on D132662

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1743959 Part 0 - Remove static nsXULScrollFrame::AddRemoveScrollbar helper.

The static AddRemoveScrollbar() helper is meant to adjust the scroll port and
test whether the scrollbar fits, but its interface is obscure. By expanding the
helper in-place, the code should now become easy to follow, and we can also
remove the wordaround that sets the bool:1 bitfield.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f651c6b3310d
Part 0 - Remove static nsXULScrollFrame::AddRemoveScrollbar helper. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9cd0be79e424
Part 1 - Make mScrollPort private, and add a getter and a setter for it. r=emilio
https://hg.mozilla.org/integration/autoland/rev/6ec8558fc869
Part 2 - Simplify the computation regarding the space occupied by scrollbars in TryLayout. r=hiro

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f651c6b3310d
https://hg.mozilla.org/mozilla-central/rev/9cd0be79e424
https://hg.mozilla.org/mozilla-central/rev/6ec8558fc869