1743995 - DNS cache can not get TTL from DNS-over-HTTPS

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[fantasyfate]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Enable DNS-over-HTTPS, visit "https://www.example.com/", and observe TTL from Expires (Seconds) in "about:networking#dns"

Actual results:

The TTL is 60 seconds.

Expected results:

The initial TTL for "www.example.com" DNS record is 86400 seconds, so it is highly unlikely to get 60 seconds TTL every time, which seems to be controlled by network.dnsCacheExpiration

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1743995 - DNS cache can not get TTL from DNS-over-HTTPS r=#necko

If mTTL is initialized to UINT32_MAX then the update condition when
adding a new IP via DOHResp::Add will never be triggered (a TTL can
never be larger than UINT32_MAX).
So it is better to have it be initialized to 0.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1743995 - Add test for TTL using TRR r=#necko

Depends on D132697

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/839eb1957f91
DNS cache can not get TTL from DNS-over-HTTPS r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/9873e362ffb2
Add test for TTL using TRR r=necko-reviewers,kershaw

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/839eb1957f91
https://hg.mozilla.org/mozilla-central/rev/9873e362ffb2