Closed Bug 1744059 Opened 2 years ago Closed 2 years ago

UnsafeTraceRoot is not unsafe

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

In fact, UnsafeTraceRoot is the correct way to trace roots and should be renamed to reflect this.

The name probably comes from the fact that it would be unsafe to trace non-root edges using these functions. We assert that they are only called during root marking though so this is not a concern.

Assignee: nobody → jcoppeard
Status: NEW → ASSIGNED
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96820c4f0524
Rename UnsafeTraceRoot to TraceRoot as it is not unsafe to use r=sfink,mccr8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: