1744076 - The selected menu item is shifted

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[super.dukefb1]

Attachment: menu.jpg

Steps to reproduce:

1. Create a new message for a OpenPGP enabled account.
2. In the compose window: Options > OpenPGP > Subject Encryption (or Attach My Public Key)

Actual results:

Check Options > OpenPGP > Subject Encryption (or Attach My Public Key), you will find the entire menu item was shifted right.

Expected results:

The selected menu item should not be shifted.

Comment 1

[Richard Marti (:Paenglab)]

Alex, can you say why the needsgutter isn't applied on this menupopup? It should be applied through this code: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/menupopup.js#17-37.

When I set this attribute in the XHTML directly it is removed on runtime.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1744076 - [Win] Fix missing gutter for OpenPGP compose menu items.r=Paenglab

Comment 3

[Alessandro Castellani [:aleca]]

The issue is due to the fact that our code was adding the hidden="false" attribute to those menu item, so they were excluded from that query selector because of the not:([hidden]) condition.
Patch with the fix ready for review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ee10762fcfb
[Win] Fix missing gutter for OpenPGP compose menu items.r=Paenglab