1744167 - nsIMsgLocalMailFolder.addMessageBatch() skips last line of message without line endings

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Ben Campbell]

The implementation of nsIMsgLocalMailFolder.addMessageBatch() was leaving off the trailing line of any messages without a final line ending.
It uses nsParseNewMailState, which reads messages line-by-line (it's derived from nsMsgLineBuffer). But it only processes lines with a line ending. To process anything left over, Flush() needs to be called, and addMessageBatch() doens't do that.

addMessageBatch() is only used by test code.
Some generated test messages don't have a trailing line ending, although I think that it is masked elsewhere, where a synthetic '\n' is added.

Comment 1

[Ben Campbell]

Attachment: Bug 1744167 - Fix test_ext_messages_get.js to not rely on synthesised LF in test message. r=mkmelin

Comment 2

[Ben Campbell]

Attachment: Bug 1744167 - Fix nsIMsgLocalMailFolder addMessageBatch() for messages without trailing CRLF. r=mkmelin

addMessageBatch() was leaving off the trailing line of any messages without
a final line ending. It uses nsParseNewMailState (derived from
nsMsgLineBuffer), which doesn't process trailing data unless
nsMsgLineBuffer::Flush() is called.
This patch also fixes nsMsgLineBuffer::Flush().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c1f290667663
Fix test_ext_messages_get.js to not rely on synthesised LF in test message. r=mkmelin
https://hg.mozilla.org/comm-central/rev/9014e82d837d
Fix nsIMsgLocalMailFolder addMessageBatch() for messages without trailing CRLF. r=mkmelin