174424 - Fix problem in handling of Choti E-Matra (093f)

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Prabhat Hegde]

Finally got a chance to document the code and clean up logic to solve some
irritating bugs in the handling of matras. A brief look at the bbc hindi web
site with and without the patch should illustrate this problem.

Ref Site: http://bbc.cu.uk/hindi

Comment 1

[Prabhat Hegde]

Attachment: Patch for matra fixes as well as documentation of code

Documented the code and fixed a few bugs. Will format code before checkin (For
spaces & tabs). Masaki - can you pl review and check-in. Since i am the
developer, i guess this does'nt require a sr=? thanks.

Comment 2

[Simon Montagu :smontagu]

Is the Hindi shaper built by default? If so, the patch needs sr. If not, sr is
"not required but strongly encouraged".
http://www.mozilla.org/hacking/reviewers.html#what-code-needs-super-review

Comment 3

[Roland Mainz]

Comment on attachment 102851 [details]
Patch for matra fixes as well as documentation of code

Nit: Please don't tell me that the "hole" in the right border of the box is
cased by tabs...
-- snip --
+ *									  *
+ * Notations used to describe Devanagari Script Generic Info:		  *
+ * D : Vowel-Modifiers (U+0901 - U+0903)				  *
+ * V : Vowels	(U+0905 - U+0913) & (U+0960, U+0961)			   *
+ * C : Consonants	(U+0915 - U+0939)				      
*
+ * M : Matras	(U+093E - U+094C)	& (U+0962, U+0963)		       
 *
+ * H : Halant	(U+094D)						   *
+ * N : Nukta (U+093C)							  *
+ *									  *
-- snip --

Beyond that the patch looks fine (not a diff from the CVS root but I don't care
about that detail), r=[e-mail] if you make
sure that we do not add new TABs to the CVSs (we have bugs for the old TABs in
CTL code so you don't need to fix them here... :)

Comment 4

[Masaki Katakai]

I'll check in the patch to Trunk.

Comment 5

[Masaki Katakai]

checked into Trunk after fixing Tabs.