Closed Bug 1744264 Opened 6 months ago Closed 6 months ago

Improve the precision of CPU data shown on about:processes on Linux

Categories

(Toolkit :: Performance Monitoring, enhancement, P3)

Desktop
Linux
enhancement

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The CPU data shown on about:processes on Linux is as 10ms resolution. Using clock_gettime we can get values with a ns precision for processes and threads of the parent process.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f350df166e2
Improve the precision of CPU data shown on about:processes on Linux, r=gerald.

Backed out for causing bustages on ProcInfo_linux.cpp. CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/b39067ed9d0ad4ba52af7f690c00a103439984e4

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=2f350df166e2f16d0f6bbec7ae9a0930b3fd4d70&selectedTaskRun=QnYorZ6JRnuMBDq0GdrXIw.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=360366324&repo=autoland&lineNumber=39002

Failure message : /builds/worker/checkouts/gecko/toolkit/components/processtools/ProcInfo_linux.cpp:331:25: error: use of undeclared identifier 'strchrnul'; did you mean 'strchr'?

Flags: needinfo?(florian)
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47add4f70615
Improve the precision of CPU data shown on about:processes on Linux, r=gerald.

(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #3)

Failure message : /builds/worker/checkouts/gecko/toolkit/components/processtools/ProcInfo_linux.cpp:331:25: error: use of undeclared identifier 'strchrnul'; did you mean 'strchr'?

Sorry about that, it looks like the strchrnul function doesn't exist on Android, I changed the code to not need it.

Flags: needinfo?(florian)
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.