Closed Bug 1744282 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 31879 - [@container] Don't reattach fieldset while being laid out

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31879 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31879
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

[@container] Don't reattach fieldset while being laid out

Fieldsets were fully re-attached when any child were re-attached to
change the box structure for rendered legends. If the fieldset is a
container for size container queries, this meant the LayoutObject for
the fieldset would be destroyed while being laid out.

Instead, re-attach all descendants of fieldset, not the fieldset itself.

Bug: 1275087
Change-Id: I4bee17065828e97f46f920eb1077581b33e78d7e
Reviewed-on: https://chromium-review.googlesource.com/3312998
WPT-Export-Revision: 6c447bd47b179392a03f6b843955ce7a7663cd9a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/container-queries/fieldset-legend-change.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a7277c89649 [wpt PR 31879] - [@container] Don't reattach fieldset while being laid out, a=testonly https://hg.mozilla.org/integration/autoland/rev/aa0f52421cb6 [wpt PR 31879] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4a7277c89649
https://hg.mozilla.org/mozilla-central/rev/aa0f52421cb6

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.