Closed Bug 1744324 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31882 - URLPattern: Emit `{}` around custom names followed by a regexp group.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31882 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31882
Details from upstream follow.

Ben Kelly <wanderview@chromium.org> wrote:

URLPattern: Emit {} around custom names followed by a regexp group.

This CL fixes another problem case from:

https://github.com/WICG/urlpattern/issues/145

In this case we need to preserve { ... } braces around a named group
followed by a group that may be emitted in regexp ( ... ) group. We
don't want {:foo}(.*) to be changed to :foo(.*) since that changes
the meaning from two groups to a single group.

Bug: 1263673
Change-Id: Ifc073d7bfb10f437180393b34cc3bf3c869d7f68

Reviewed-on: https://chromium-review.googlesource.com/3315419
WPT-Export-Revision: 608387e1d65ef15dbb008c8970273c7d008b9db3

PR 31882 applied with additional changes from upstream: ba47328a5138c4fbbc0841dc2f5bf31ab4da0b33
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf8631a00451
[wpt PR 31882] - URLPattern: Emit `{}` around custom names followed by a regexp group., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/cf8631a00451

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.