1744442 - All day events don't have the start/end time widget disabled

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Rachel Martin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Create an event, make it all day. As soon as you click the "all day" check box, the start and end time input should be disabled like it was in TB 78. The same happens when editing an all day event.

Comment 1

[Rachel Martin]

Alice, could you please find the regression. This is very straight forward. Working in TB 78, not working in TB 91, of 95 beta. Didn't try Daily.

Comment 2

[WaltS48 [:walts48]]

I can reproduce using 95.0b5 if you mean not dimmed, indicating it is disabled.

I can't make any changes to the times, only the date, and would consider that as disabled.

Comment 3

[Rachel Martin]

Yes, the time picker appears, but changes are discarded. Please compare to the TB 78 behaviour.

Comment 4

[WaltS48 [:walts48]]

(In reply to Rachel Martin from comment #3)

Yes, the time picker appears, but changes are discarded. Please compare to the TB 78 behaviour.

Discarded means the same as disabled to me. I can't make a time change, never paid attention to how it was in previous versions because I was creating an All Day event.

Comment 5

[Rachel Martin]

Likely broken here:
https://searchfox.org/comm-central/diff/9dae3c5143be50c5102e0ddf937db2e128eee5c2/calendar/lightning/content/lightning-item-iframe.js#1961
https://searchfox.org/comm-central/diff/e3cb9833ac6db1db6d0d52d634b0c1274d4d8463/calendar/lightning/content/lightning-item-iframe.js#1975

Comment 6

[Rachel Martin]

https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1744442-all-day-time-widget.patch

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1744442-timepicker-disabled.diff

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b4d4250e3f1d
Fix non-disabled time widgets for all day events, use set/removeAttribute() instead of toggleAttribute(). r=darktrojan