1744466 - Make "More from Mozilla" strings localizable

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

They are currently in content; once we're confident that they won't change any more for 97, we should move them into the proper place so they will be localized.

Comment 1

[Meg Viar [:mviar]]

Hi @mstriemer - Any thoughts on whether we should we add this to preferences.ftl or keep it in a separate file in the preferences folder next to https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/preferences/preferences.ftl?

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1744466 - Make "More from Mozilla" strings localizable

Comment 3

[Meg Viar [:mviar]]

Hi Gijs, I think Mark is on PTO. Do you have any thoughts on the question above?

Comment 4

[:Gijs (he/him)]

I think either is fine. We don't have separate ftl files for the other panes either, so although the file is pretty big that still seems fairly reasonable. Equally, it'd be easier to hg mv the file if we keep it separate, keep history there and keep the files more manageable in size, so there's an argument for doing that?

Comment 5

[Meg Viar [:mviar]]

Do we want the Mozilla Rally product card to show for all locales?

Comment 6

[Meg Viar [:mviar]]

Found answer re: Mozilla Rally approved locales in this slack thread. Limit to EN-US only.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

After discussion with desktop team, will translate, but leave explicit clear comments about what to localize, what it means, etc.

Comment 8

[Meg Viar [:mviar]]

Flod pointed out that the guideline from content is to use lowercase "internet", not uppercase. Are we good to swap out instances of uppercase internet in the More from Mozilla strings?

Comment 9

[Meg Viar [:mviar]]

cc Brian on the above question re: lowercase "internet"

Comment 10

[Vtay]

(In reply to Meg Viar from comment #9)

cc Brian on the above question re: lowercase "internet"

we are ok to swap to lowercase 'internet'

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b6b70d9b86f
Make "More from Mozilla" strings localizable r=preferences-reviewers,fluent-reviewers,flod,Gijs

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8b6b70d9b86f

Comment 13

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this enhancement using Firefox Release 97.0 fr, de, ar, zh-CN, RU, es-ES locales (Build ID: 20220202182137) on Windows 10 x64, macOS 11.6, and Linux Mint 20.2.

• The “More from Mozilla” strings are localized.