1744504 - iOS: Skip running in indexbuilds

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

Since Xcode 13 Xcode runs a so called indexbuild, which triggers the Glean parser script.
Then it gets triggered again during a build.
This can lead to problems.

See Firefox iOS discussion: https://github.com/mozilla-mobile/firefox-ios/discussions/9511
See R.swift issue, too: https://github.com/mac-cain13/R.swift/issues/719

The "fix" right now is to skip work in indexbuild runs.
Longer term we should advise iOS projects to run the parser & code generator in a different stage of the build.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1889

Comment 2

[Jan-Erik Rediger [:janerik]]

badboy merged PR #1889: "Bug 1744504 - iOS: Skip code generation in indexbuild build" in c8cd4b3.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Quick note that this change is also needed for projects that use SwiftUI - otherwise SwiftUI Previews break.

This is actually an interesting case because with SwiftUI Previews (the mode where you have your code and a rendered UI side-by-side) results in many many frequent compiles or at least index builds. Since anything on the build path slows things down, I think we should consider for our iOS projects to remove the invocation to sdk_generator.sh from the build system and instead only call it manualy when telemetry changes are being worked on.