Closed Bug 1744873 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31949 - Rename windowControlsOverlay.getBoundingClientRect->getTitlebarAreaRect

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31949 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31949
Details from upstream follow.

Amanda Baker <ambake@microsoft.com> wrote:

Rename windowControlsOverlay.getBoundingClientRect->getTitlebarAreaRect

This change renames the existing JS API for Window Controls Overlay
(WCO) from:
navigator.windowControlsOverlay.getBoundingClientRect()
to
navigator.windowControlsOverlay.getTitlebarAreaRect()

The new name addresses feedback about how the original API name was
misleading since windowControlsOverlay.getBoundingClientRect() actually
returns the available area next to the overlay.

The new name--getTitlebarAreaRect--matches the CSS environment
variables: titlebar-area-x/y/width/height

Bug: 1276216
Change-Id: I95e2bc680d124aaa69f0c12ea0ba41399b77185c

Reviewed-on: https://chromium-review.googlesource.com/3319288
WPT-Export-Revision: 3ca67d245208d0d14c88547bb200cfc91f7fe971

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL: 7

Chrome

OK : 1
PASS: 4
FAIL: 3

Safari

OK : 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-window-controls-overlay.html
the windowControlsOverlay object should exist on the navigator object: FAIL (Chrome: PASS, Safari: FAIL)
visible should be a member of the windowControlsOverlay object: FAIL (Chrome: PASS, Safari: FAIL)
visible should be false: FAIL (Chrome: PASS, Safari: FAIL)
getTitlebarAreaRect should be a method of the windowControlsOverlay object: FAIL (Chrome: FAIL, Safari: FAIL)
getTitlebarAreaRect return type should be DOMRect: FAIL (Chrome: FAIL, Safari: FAIL)
getTitlebarAreaRect should return a empty DOMRect: FAIL (Chrome: FAIL, Safari: FAIL)
ongeometrychange should be a member of the windowControlsOverlay object: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ff886b42fc5 [wpt PR 31949] - Rename windowControlsOverlay.getBoundingClientRect->getTitlebarAreaRect, a=testonly https://hg.mozilla.org/integration/autoland/rev/feb7034127cd [wpt PR 31949] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7ff886b42fc5
https://hg.mozilla.org/mozilla-central/rev/feb7034127cd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.