1744895 - justify-content:left/right doesn't work with vertical row-oriented flexbox and abspos children

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

+++ This bug was initially created as a clone of Bug #1715661 +++

My patch in bug 1715661 is not complete. justify-content:left/right in vertical row-oriented flexbox maps to the wrong side.

For abspos children under flexbox, we failed this test https://wpt.live/css/css-flexbox/abspos/flex-abspos-staticpos-justify-content-vertWM-002.html

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1744895 Part 1 - Extract a helper mapping justify-*:{left|right} to {start|end}. r?dholbert

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1744895 Part 2 - Fix justify-*:{left|right} mapping for vertical row-oriented flex containers. r?dholbert

Currently, we use IsPhysicalLTR() to query whether the start side of the
physical left <-> right axis. However, for vertical row-oriented flex
containers, physical left <-> right axis is its cross axis. We really should
query IsBidiLTR() instead because its main axis is parallel to line-left <->
line-right axis (i.e. inline axis).

flexbox-justify-content-wmvert-003.html is adapted from
flexbox-justify-content-wmvert-002.html.

Depends on D133167

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1744895 Part 3 - Fix justify-*:{left|right} mapping for abspos children of flex containers. r?dholbert

Depends on D133168

Comment 4

[Daniel Holbert [:dholbert]]

Marking this as blocking the compat2021 metabug, since part 3 here fixes our failure in WPT test flex-abspos-staticpos-justify-content-vertWM-002.html , which is in the compat2021 test set.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd1719d2c014
Part 1 - Extract a helper mapping justify-*:{left|right} to {start|end}. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e31135ea4028
Part 2 - Fix justify-*:{left|right} mapping for vertical row-oriented flex containers. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9eb74149f75b
Part 3 - Fix justify-*:{left|right} mapping for abspos children of flex containers. r=dholbert

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dd1719d2c014
https://hg.mozilla.org/mozilla-central/rev/e31135ea4028
https://hg.mozilla.org/mozilla-central/rev/9eb74149f75b

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32051 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot