1744925 - "WebDriver:ElementClear" emits an extra "change" event for content editable elements

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As it can be seen for the following try build our implementation send an extra change event that is not expected:

[task 2021-12-08T08:22:20.275Z] 08:22:20     INFO - TEST-UNEXPECTED-FAIL | /webdriver/tests/element_clear/clear.py | test_contenteditable - AssertionError: assert ['focus', 'change', 'blur'] == ['focus', 'blur']
[task 2021-12-08T08:22:20.275Z] 08:22:20     INFO - session = <Session 92a354b7-361e-493d-bfb2-cfc0a2dc98ca>
[task 2021-12-08T08:22:20.275Z] 08:22:20     INFO - inline = <function inline.<locals>.inline at 0x7f91a82c57b8>
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO - add_event_listeners = <function add_event_listeners.<locals>.add_event_listeners at 0x7f91a82c5a60>
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO - tracked_events = ['blur', 'change', 'focus']
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO - 
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -     def test_contenteditable(session, inline, add_event_listeners, tracked_events):
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -         session.url = inline("<p contenteditable>foobar</p>")
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -         element = session.find.css("p", all=False)
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -         add_event_listeners(element, tracked_events)
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -         assert element.property("innerHTML") == "foobar"
[task 2021-12-08T08:22:20.276Z] 08:22:20     INFO -     
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO -         response = element_clear(session, element)
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO -         assert_success(response)
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO -         assert element.property("innerHTML") == ""
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO - >       assert_events_equal(session, ["focus", "blur"])
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO - 
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO - add_event_listeners = <function add_event_listeners.<locals>.add_event_listeners at 0x7f91a82c5a60>
[task 2021-12-08T08:22:20.277Z] 08:22:20     INFO - element    = <Element 0fb75cb2-4ddf-45a8-acef-c1d0b982e407>
[task 2021-12-08T08:22:20.278Z] 08:22:20     INFO - inline     = <function inline.<locals>.inline at 0x7f91a82c57b8>
[task 2021-12-08T08:22:20.278Z] 08:22:20     INFO - response   = <Responsetatus=200 body={"value": null}>
[task 2021-12-08T08:22:20.278Z] 08:22:20     INFO - session    = <Session 92a354b7-361e-493d-bfb2-cfc0a2dc98ca>
[task 2021-12-08T08:22:20.278Z] 08:22:20     INFO - tracked_events = ['blur', 'change', 'focus']

The broken code can be seen here:
https://searchfox.org/mozilla-release/rev/477b22c1301d9c4367f038d0b2e352289b12a045/remote/marionette/interaction.js#356-364

Means we just have to remove the line which emits the change event.

Comment 1

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1744925 - [marionette] Fix extra change event with WebDriver:ElementClear for content editables

Fixed extra change event being emitted when WebDriver:ElementClear is
called for content editable elements.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a92d64d6fd2e
[marionette] Fix extra change event with WebDriver:ElementClear for content editables r=webdriver-reviewers,whimboo

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a92d64d6fd2e