1744985 - Email attachment of .vcs file did not prompt to add calendar entry

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Patrick Cloke [:clokep]]

Attachment: XXXXX_en_US_Service_Appointments.vcs

...and importing it directly ended up with no events.

I have no idea if it is a valid event but was sent to me from my mechanic via xtime.com, so is probably not completely unique.

I've attached a redacted version of the file, I can send the original in private if necessary.

From my brief reading vcs == vCal, an older version of iCal and is supported by Thunderbird?

Comment 1

[Magnus Melin [:mkmelin]]

As a file that imports ok to me after changing the extension.
https://en.wikipedia.org/wiki/ICalendar says it's indeed an old kind of version.
File extension can also be .ical or .icalendar but should be .ics. We should loosen the checks a bit though.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1744985 - can't import vcs (vCalendar 1.0) due to file name extension. r=lasana,darktrojan!

Comment 3

[Patrick Cloke [:clokep]]

I don't think this is due to the filename extension -- I was able to import it fine without changing the file extension.

The issue is that once it was "imported" no events were found.

Comment 4

[Magnus Melin [:mkmelin]]

How did you import it?

Comment 5

[Patrick Cloke [:clokep]]

(In reply to Magnus Melin [:mkmelin] from comment #4)

How did you import it?

I believe I did "Events and Tasks" > "Import ..." while on the calendar tab. I tried this again (after renaming the file) and it did work, so I must be forgetting exactly what I did. (I've also upgraded betas since then, not sure if that matters.)

Will the given patch also give an option to import from an email like ics files do? It looks like it only deals with importing the file manually.

Comment 6

[Magnus Melin [:mkmelin]]

The patch only enables manual import.

What was the mime type of the file when it came in? If it's not properly set as text/calendar not sure there's much we can do. If it had the right type, then I'd assume it would have been handled correctly to begin with.

Comment 7

[Patrick Cloke [:clokep]]

(In reply to Magnus Melin [:mkmelin] from comment #6)

The patch only enables manual import.

What was the mime type of the file when it came in? If it's not properly set as text/calendar not sure there's much we can do. If it had the right type, then I'd assume it would have been handled correctly to begin with.

It seems to have not been set properly. Sad times! At least assuming I'm looking at the right spot:

Content-Type: application/octet-stream; 
	name=XXXX_en_US_Service_Appointments.vcs
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; 
	filename=XXXX_en_US_Service_Appointments.vcs

Comment 8

[Magnus Melin [:mkmelin]]

Yes, not much to do about that from our side.

Comment 9

[Lasana Murray]

Attachment: Screenshot_2021-12-16_05-43-11.png

If prompt means the imip bar, it shows for me on Daily. The events were also added however the imip bar does not seem to remember the event was added which is a bug.

Comment 10

[Magnus Melin [:mkmelin]]

If it's an email you sent yourself, probably it got the right mime type and things work out.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c9c611e56afe
can't import vcs (vCalendar 1.0) due to file name extension. r=lasana,darktrojan

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9255332 [details]
Bug 1744985 - can't import vcs (vCalendar 1.0) due to file name extension. r=lasana,darktrojan!

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: can't import "ics"
Testing completed (on c-c, etc.): on beta for a while
Risk to taking this patch (and alternatives if risky): super low risk

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9255332 [details]
Bug 1744985 - can't import vcs (vCalendar 1.0) due to file name extension. r=lasana,darktrojan!

[Triage Comment]
Approved for esr91

Comment 14

[Rob Lemley [:rjl]]

The calendar import code has changed; the patch does not apply on c-esr91. getItemsFromIcsFile() doesn't exist. Can you make a esr91 version?

Comment 15

[Magnus Melin [:mkmelin]]

Not important enough, let's wontfix then.