1745060 - Rewrite the devtool tests which use SVGPathSeg APIs

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, task, P2)

Description

[Boris Chiou [:boris]]

Bug 1388931 removes SVGPathSeg APIs, but we are still using SVGPathSeg APIs in some devtool tests in this folder:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/animation/test

I would like to do some minor updates and skip some tests Bug 1388931. A preferable way is to use getComputedStyle(path).d to retrieve the path string, and check the path string, just like what we do in web-platform-test. I guess we need to rewrite the js code to check the path string to makes sure we pass some vertices.

Comment 1

[Boris Chiou [:boris]]

There is a polyfill we may use for testing: https://github.com/progers/pathseg

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1745060 - Rewrite the devtool tests which use SVGPathSeg APIs r=boris

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=53940db42dc16f8ff83432d9f759b95a38784957

Comment 4

[Robert Longson [:longsonr]]

Attachment: Bug 1745060 - Rewrite the devtool tests which use SVGPathSeg APIs r=boris

Comment 5

[Robert Longson [:longsonr]]

Is comment 3 executing the devtools tests? If not can you tell me what I need to run please?

I've never run these tests before. I'm not even sure the tests are supposed to pass. Many/most/all of them are marked fail-if = ["a11y_checks"] e.g. https://searchfox.org/mozilla-central/source/devtools/client/inspector/animation/test/browser.toml#107

Comment 6

[Alexandre Poirot [:ochameau]]

(In reply to Robert Longson [:longsonr] from comment #5)

Is comment 3 executing the devtools tests? If not can you tell me what I need to run please?

I've never run these tests before. I'm not even sure the tests are supposed to pass. Many/most/all of them are marked fail-if = ["a11y_checks"] e.g. https://searchfox.org/mozilla-central/source/devtools/client/inspector/animation/test/browser.toml#107

This try run isn't running the devtools mochitests. The tests don't look disabled. I can see at least one which should be failing that isn't disabled.
https://searchfox.org/mozilla-central/source/devtools/client/inspector/animation/test/browser_animation_infinity-duration_summary-graph.js#126

There is a preset handy for running all devtools tests ./mach try fuzzy --preset devtools-linux
If you are using try fuzzy you can use ./mach try fuzzy devtools/client/inspector/animation/test/ and mochitest-devtools-chrome as search string to execute only the animation folder tests.

Comment 7

[Alexandre Poirot [:ochameau]]

You can also run them locally via ./mach test devtools/client/inspector/animation/test/

Comment 8

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=cc10a8ce6efe8e6b053c04cd991a80fa5304132e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c630adf0b0c1
Rewrite the devtool tests which use SVGPathSeg APIs r=boris,devtools-reviewers,ochameau

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c630adf0b0c1