Window control(minimize/restore/close button) are missing in Fullscreen size mode if MenuBar is enabled
Categories
(Toolkit :: Themes, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox95 | --- | wontfix |
firefox96 | --- | verified |
firefox97 | --- | verified |
People
(Reporter: alice0775, Assigned: emilio)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Steps to reproduce:
- Enabled MenuBar
- Enter fullscreen(F11)
- Move mouse pointer to the top of the screen
Actual Results:
Window control(minimize/restore/close button) are missing
Expected Results:
Window control(minimize/restore/close button) should be provided.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cc067906622d2660d8eda3b6abe1c71d4a8e102a&tochange=9785ceff3f61c52823d82b3f217b4897bcebaad3
Assignee | ||
Comment 2•2 years ago
|
||
Since the menubar is not a fullscreentoolbar, it will be collapsed when
on fullscreen.
Assignee | ||
Comment 3•2 years ago
|
||
I just noticed it was broken and buttons appeared to jump, since tabs
now have a little bit of margin.
Depends on D133399
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f007b3b66bb9 Don't hide the #TabsToolbar titlebar buttons when in fullscreen, even if the menubar is shown. r=dao,desktop-theme-reviewers
Comment 5•2 years ago
|
||
bugherder |
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8bb2fe9d440 Fix Linux auto-hidden menubar height. r=dao,desktop-theme-reviewers,stransky
Comment 7•2 years ago
|
||
bugherder |
Comment 8•2 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 9•2 years ago
|
||
Comment on attachment 9254606 [details]
Bug 1745189 - Don't hide the #TabsToolbar titlebar buttons when in fullscreen, even if the menubar is shown. r=dao
Beta/Release Uplift Approval Request
- User impact if declined: Missing window controls in fullscreen with menubar always-shown.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple CSS tweak.
- String changes made/needed: none
Assignee | ||
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment on attachment 9254606 [details]
Bug 1745189 - Don't hide the #TabsToolbar titlebar buttons when in fullscreen, even if the menubar is shown. r=dao
Approved for 96.0b8
Comment 11•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Reproduced this issue on Firefox 95.0.2 on Windows 10 x64.
Verified as fixed using the latest Nightly 97.0a1 on Windows 10 x64 - the minimize/restore/close buttons are displayed while the Menu bar is enabled and Firefox is in full screen.
Comment 13•2 years ago
|
||
I can confirm this issue is fixed, I verified using Firefox 96.0b8 on Windows 10 x64.
Updated•2 years ago
|
Description
•