174524 - Tidy up Bugzilla::{Util,Config}, and lazily-load unneeded modules

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Bradley Baetz (:bbaetz)]

I'll attach a patch which does two things:

a) Move the POD to under an __END__ line. This allows the perl parser to avoid
having to skip over all the POD, since it stops as soon as it gets to the
__END__ line. The perf improvment of this was not measurable on my unloaded
PIII-500.

b) load Data::Dumper and File::Temp only when required. This speeds up loading
Bugzilla::Config quite a bit, especially when combined with
http://www.template-toolkit.org/pipermail/templates/2002-October/003790.html,
which does the same thing to TT. (myk, you may want to apply that locally to bmo
when you upgrade TT).

With both these changes (incl the TT patch), |time perl -w -e 'use
Bugzilla::Config'| goes from 0.54s to 0.20s, roughly.  I can save about another
0.04s by removing the |use Safe| thing I added, and the rest is just generic
noise, according to dprof.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: v1

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: s/use/require/ in globals.pl, too

This is needed to get the speed increase on a real script (Except once every
hour, of course)

Comment 3

[Joel Peshkin]

Comment on attachment 102916 [details] [diff] [review]
s/use/require/ in globals.pl, too

With the change to use....

{
    local $Data::Dumper::Sortkeys;
    local $Data::Dumper::Terse;
    local $Data::Dumper::Indent;
    }	   

In Config.pm...

r=joel

Comment 4

[Bradley Baetz (:bbaetz)]

Checked in, with that change (needed because perl 5.6 doens't like the use vars
trick I had to pull, probably correctly)