1745248 - Allow address autofill to be enabled per country independently of credit card autofill

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Tim Giles [:tgiles]]

Currently adding a new supported country to extensions.formautofill.supportedCountries will enable both credit card autofill and address autofill for that country. However credit card autofill and address autofill should be able to be enabled independently from each other as we enable Form Autofill for more countries.

The current idea is to create a new pref extensions.formautofill.addresses.supportedCountries so that we can ensure non-tested countries do not have address autofill enabled by default. The address autofill feature will still be available in about:preferences but will not be supported until we have an opportunity to test and fix issues of the feature in these future countries.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Allow address autofill to be enabled per country independently of credit card autofill. r=dimi!,sgalich!

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi!,sgalich!,markh!

Depends on D133501

Comment 3

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Allow each autofill feature to hide its prefs if the feature is not supported in the search region. r=dimi!,sgalich!

Depends on D133818

Comment 4

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi!,sgalich!

Depends on D133819

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1808ec2fe97
Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/8aeb5a348950
Allow each autofill feature to hide its prefs if the feature is not supported in the search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/ef2454116a21
Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi,sgalich

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing Mochitests with software webrender enabled failures in browser/extensions/formautofill/test/browser/browser_first_time_use_doorhanger.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ea700301581f02192a46f6fa2b4e568b2c34bd9

Push with failures

Failure log

Comment 7

[Tim Giles [:tgiles]]

Alright, fixed the failing tests. Let's try this again.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03dd6cedf996
Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/b09a96820c2c
Allow each autofill feature to hide its prefs if the feature is not supported in the search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/b39b99edef97
Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi,sgalich

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/03dd6cedf996
https://hg.mozilla.org/mozilla-central/rev/b09a96820c2c
https://hg.mozilla.org/mozilla-central/rev/b39b99edef97

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out 3 changesets (Bug 1745248) for causing issues with FormAutofill.jsm.
Backout link: https://hg.mozilla.org/integration/autoland/rev/08b8e75ae061b5fd04493ff7f11cb6b62851817e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49237fea6582
Fix lint failure. a=lint-fix. CLOSED TREE

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/49237fea6582

Comment 14

[Sandor Molnar[:smolnar]]

Backout merged to central:

Backout link: https://hg.mozilla.org/mozilla-central/rev/08b8e75ae061b5fd04493ff7f11cb6b62851817e

Comment 15

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Add form autofill pref migration and tests. r=dimi!,sgalich!

Depends on D133820

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06d57e874522
Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey
https://hg.mozilla.org/integration/autoland/rev/c7212ce535e4
Allow each autofill feature to hide its prefs if the feature is not supported in the search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/f54ce6b7dd26
Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/324a6acb8612
Add form autofill pref migration and tests. r=dimi,sgalich

Comment 18

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/06d57e874522
https://hg.mozilla.org/mozilla-central/rev/c7212ce535e4
https://hg.mozilla.org/mozilla-central/rev/f54ce6b7dd26
https://hg.mozilla.org/mozilla-central/rev/324a6acb8612

Comment 19

[Iulian Moraru]

Backed out for causing issues with credit card sync.

Backout link

Comment 20

[Mark Hammond [:markh] [:mhammond]]

(In reply to Iulian Moraru from comment #19)

Backed out for causing issues with credit card sync.

Backout link

Thanks for that, but I think we also will want another patch to "reserve" UIVersion 123 - IIUC, any profiles where this has run will have set the "browser.migration.version" pref to 123 - so when someone else comes along and adds the next migration, they will use 123 again, but those profiles will not run it. A comment noting that 123 should not be reused will probably suffice.

Comment 21

[Tim Giles [:tgiles]]

Attachment: Bug 1745248 - Reserve UI version 123 due to multiple backouts involving this UI version.

Comment 22

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4bc3a951bcee

Comment 23

[Tim Giles [:tgiles]]

Steps to verify this bug:

1. Ensure region detection works as expected for address and credit card autofill. This can be done by the following:
   1. Set browser.search.region to "US"
   2. Set extensions.formautofill.addresses.supported to "detect"
   3. Set extensions.formautofill.creditCards.supported to "detect"
   4. Restart browser
   5. Navigate to about:preferences and search for "Saved Credit Cards" and "Saved Addresses"
   6. The two buttons for management dialogs should appear and be available for use
   7. Set browser.search.region to "DE"
   8. Set extensions.formautofill.creditCards.supportedCountries to "US,CA,DE"
   9. Restart browser
   10. Navigate to about:preferences and search for "Saved Credit Cards" and "Saved Addresses"
   11. Only "Saved Credit Cards" should be available to use, the "Saved Addresses" button shouldn't exist at this point.
   12. Set extensions.formautofill.creditCards.supportedCountries back to "US,CA" and set extensions.formautofill.addresses.supportedCountries to "US,CA,DE"
   13. Restart the browser
   14. Navigate to about:preferences and search for "Saved Credit Cards" and "Saved Addresses"
   15. Only "Saved Addresses" should be available to use, the "Saved Credit Cards" button shouldn't exist at this point.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/229e5309bc92
Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey
https://hg.mozilla.org/integration/autoland/rev/7ceca0dff062
Allow each autofill feature to hide its prefs if the feature is not supported in the search region. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/76ddec1f1d48
Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi,sgalich
https://hg.mozilla.org/integration/autoland/rev/104a9dfbecb6
Add form autofill pref migration and tests. r=dimi,sgalich

Comment 25

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/229e5309bc92
https://hg.mozilla.org/mozilla-central/rev/7ceca0dff062
https://hg.mozilla.org/mozilla-central/rev/76ddec1f1d48
https://hg.mozilla.org/mozilla-central/rev/104a9dfbecb6

Comment 26

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 99.0a1 (build id: 20220210213101), everything is working as expected. We verified the bug following the steps provided in comment 23 and also we performed exploratory testing around those prefs using different locale builds.