1745262 - Print preview remains visible while printing using system dialog

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P3)

Description

[Mark Striemer [:mstriemer]]

Attachment: image.png

STR

1. Start a print
2. Click "Print using the system dialog..."

Expected results: The preview dialog closes and system dialog opens
Actual results: The preview dialog closes, but the preview itself is still visible

This is a regressions from bug 1732921 since the active preview browser has visibility: visible when it is selected, but it isn't cleared when the system dialog is shown

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1745262 - Ensure print previews/spinners hidden when system dialog is open r?emilio

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1732921

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39209bfb6fef
Ensure print previews/spinners hidden when system dialog is open r=emilio

Comment 5

[Mark Striemer [:mstriemer]]

Comment on attachment 9254628 [details]
Bug 1745262 - Ensure print previews/spinners hidden when system dialog is open r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: The print preview is left open even when it is no longer a reflection of the chosen settings when using the system print dialog
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Print a page

2. Select "Print using system dialog..."

Expected: the tab modal dialog is entirely hidden and the system dialog opens
Actual: the preview portion of the tab modal dialog remains visible, and the system dialog opens

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The handling of nested children with visibility: visible changed. Since the preview what using that, its behaviour has changed in this case.

This is a one-line CSS fix

• String changes made/needed: No

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/39209bfb6fef

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/39209bfb6fef

Comment 8

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 96.0b4 under macOS 11.6.1.

The issue is fixed on Firefox 97.0a1 (2021-12-13). Tests were performed on macOS 11.6.1, Ubuntu 20.04 and Windows 11. Will verify the fix on 96 as well when it will be pushed.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9254628 [details]
Bug 1745262 - Ensure print previews/spinners hidden when system dialog is open r?emilio

Approved for 96.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec6ee7f30874

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified the fix on 96.0b6 (treeherder build) as well. Tests were performed on macOS 11.6.1, Ubuntu 20.04 and Windows 7.