Remove osfile.jsm from browser/components/extensions
Categories
(WebExtensions :: General, task)
Tracking
(firefox98 fixed)
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: beth, Assigned: beth)
References
Details
Attachments
(3 files, 1 obsolete file)
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
We need a way to get the current working directory here to build up the paths for the test.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Comment 3•3 years ago
|
||
Comment on attachment 9255397 [details]
Bug 1745352 - Remove osfile.jsm from browser/components/tests r?mixedpuppy
Revision D133825 was moved to bug 1745358. Setting attachment 9255397 [details] to obsolete.
Updated•3 years ago
|
Comment 6•3 years ago
|
||
The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.
Comment 7•3 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 8•3 years ago
|
||
The change in bug 1745361 only just landed, so I think we're good.
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc2c0094773c Add depth param to PathUtils.getParent to get aribtrary ancestors r=Gijs
Comment 10•3 years ago
|
||
Backed out for causing failures on test_pathutils.html
-
backout: https://hg.mozilla.org/integration/autoland/rev/89aa2c8696b7b10a4e71f95d4a468171b92bb828
-
failure log: https://treeherder.mozilla.org/logviewer?job_id=364522414&repo=autoland&lineNumber=2809
[task 2022-01-18T18:41:36.919Z] 18:41:36 INFO - TEST-PASS | dom/system/tests/test_pathutils.html | PathUtils.parent() with depth=2
[task 2022-01-18T18:41:36.919Z] 18:41:36 INFO - Buffered messages finished
[task 2022-01-18T18:41:36.920Z] 18:41:36 INFO - TEST-UNEXPECTED-FAIL | dom/system/tests/test_pathutils.html | PathUtils.parent() with depth=3 - got "/home/user", expected "/home/user/"
[task 2022-01-18T18:41:36.920Z] 18:41:36 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2022-01-18T18:41:36.921Z] 18:41:36 INFO - test_parent@chrome://mochitests/content/chrome/dom/system/tests/test_pathutils.html:193:13
[task 2022-01-18T18:41:36.921Z] 18:41:36 INFO - add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2095:34
[task 2022-01-18T18:41:36.923Z] 18:41:36 INFO - TEST-PASS | dom/system/tests/test_pathutils.html | PathUtils.parent() with depth=4
Assignee | ||
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba57b662bb72 Add depth param to PathUtils.getParent to get aribtrary ancestors r=Gijs https://hg.mozilla.org/integration/autoland/rev/0975c59084aa Remove osfile.jsm from browser/components/extensions r=mixedpuppy
Comment 12•3 years ago
|
||
Backed out for failures on test_ext_pkcs11_management.js
-
backout: https://hg.mozilla.org/integration/autoland/rev/6793034c104497653b126878d9fcf6700de1da52
-
failure log: https://treeherder.mozilla.org/logviewer?job_id=364586479&repo=autoland&lineNumber=2713
[task 2022-01-19T04:14:14.827Z] 04:14:14 INFO - TEST-START | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js
[task 2022-01-19T04:14:15.158Z] 04:14:15 WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js | xpcshell return code: 0
[task 2022-01-19T04:14:15.159Z] 04:14:15 INFO - TEST-INFO took 329ms
[task 2022-01-19T04:14:15.159Z] 04:14:15 INFO - >>>>>>>
[task 2022-01-19T04:14:15.159Z] 04:14:15 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-01-19T04:14:15.160Z] 04:14:15 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-01-19T04:14:15.160Z] 04:14:15 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-01-19T04:14:15.160Z] 04:14:15 INFO - running event loop
[task 2022-01-19T04:14:15.162Z] 04:14:15 INFO - xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js | Starting setup
[task 2022-01-19T04:14:15.162Z] 04:14:15 INFO - (xpcshell/head.js) | test setup pending (2)
[task 2022-01-19T04:14:15.162Z] 04:14:15 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - Unexpected exception TypeError: IOUtils.createDirectory is not a function at /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js:22
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - setup@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js:22:17
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:604:5
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - @-e:1:1
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - exiting test
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - OperationError: Could not parse path (undefined): NS_ERROR_FILE_UNRECOGNIZED_PATH
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - @/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/extensions/test/xpcshell/test_ext_pkcs11_management.js:26:17
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - _execute_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:668:28
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:677:5
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - @-e:1:1
[task 2022-01-19T04:14:15.163Z] 04:14:15 INFO - <<<<<<<
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 13•3 years ago
|
||
PathUtils is the only binding requires for this patch, but eventually we'll
have to migrate NativeManifests.jsm to IOUtils and then we will have to provide
it anyway.
Depends on D133842
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5e6bd275b5d Add depth param to PathUtils.getParent to get arbitrary ancestors r=Gijs https://hg.mozilla.org/integration/autoland/rev/17adef35f390 Expose IOUtils and PathUtils via Cu.importGlobalProperties r=nika https://hg.mozilla.org/integration/autoland/rev/cd7d8b76f9d0 Remove osfile.jsm from browser/components/extensions r=mixedpuppy
Comment 15•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d5e6bd275b5d
https://hg.mozilla.org/mozilla-central/rev/17adef35f390
https://hg.mozilla.org/mozilla-central/rev/cd7d8b76f9d0
Description
•