1745506 - Items <li> in numbered lists <ol> have wrong numbers on SharePoint pages

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Jiri Sluka]

Attachment: Screenshots show the appearance of the problem.

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

Use Firefox Nightly V97 either on Linux or on Windows.
Use Microsoft Office account and create new page in any Microsoft SharePoint web.
Set Firefox window size to sufficient width. A left menu column must be visible on SharePoint page.
Put text block and numbered list to page.
Create several items /rows in list. Save page.

Actual results:

Completely wrong numbers with more then 3 digits each are displayed in front of all items in numbered list.

Described problem DOES NOT occur in these cases:
Firefox 95 or lower is used.
Window width of Firefox (incl. Nightly build V97) is set narrow and left SharePoint menu column is hidden.

Expected results:

An ascending numbers starting from No. 1 should be visible in front of all items in list.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Regression affecting major site.

Thanks! I managed to repro this on a sharepoint instance that my university had, and I've got an unreduced test-case. Pretty sure this is from bug 1706346, Mats can you take a look please?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Unreduced test-case.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case.

Comment 5

[Mats Palmgren (inactive)]

Attachment: minimal testcase

Comment 6

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/jobs?repo=try&revision=b493c19135aed1730b72c3ac3784b5bd9d3b647a

Comment 7

[Mats Palmgren (inactive)]

Attachment: Bug 1745506 - Add missing initialization of an INCREMENT node that isn't in a scope, nor first in the list. r=emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56cf5b4eb781
Add missing initialization of an INCREMENT node that isn't in a scope, nor first in the list.  r=emilio

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/56cf5b4eb781

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1706346

Comment 11

[Mats Palmgren (inactive)]

Comment on attachment 9254913 [details]
Bug 1745506 - Add missing initialization of an INCREMENT node that isn't in a scope, nor first in the list. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: list item numbering is wrong in some edge cases
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed:

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32053 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9254913 [details]
Bug 1745506 - Add missing initialization of an INCREMENT node that isn't in a scope, nor first in the list. r=emilio

Approved for 96.0b5

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/57ad8956ae56