Closed Bug 1745511 Opened 2 months ago Closed 9 days ago

Expand FOG IPC to GMP process

Categories

(Core :: Audio/Video: GMP, task)

task

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(2 files)

FOG's IPC is currently not present in the GMP process. It would be nice to fix this to report the CPU time used in the GMP process through Glean.

Assignee: nobody → florian
Attachment #9254844 - Attachment description: WIP: Bug 1745511 - Expand FOG IPC to GMP process, → Bug 1745511 - Expand FOG IPC to GMP process, r=bryce!,chutten!.
Status: NEW → ASSIGNED
Depends on: 1746254

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:florian, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(florian)
Flags: needinfo?(chutten)

(In reply to Release mgmt bot [:marco/ :calixte] from comment #2)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:florian, could you have a look please?

I was waiting for bug 1746254 to land first, and I've just pushed to try again to be confident (and it looks green) : https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=d90877d8bb5909146f8b20399c1802e8d5841b8d

Flags: needinfo?(florian)
Flags: needinfo?(chutten)
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19b1136a92ec
Expand FOG IPC to GMP process, r=bryce,chutten.

Backed out changeset 19b1136a92ec (Bug 1745511) for causing mochitest failures in GMPServiceParent.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/afb99f2fbec3d8dd7e10978354a73bc29c3765d7
Push with failures, failure log.
[Update]: Also caused bc failures

Flags: needinfo?(florian)
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fadea77038a
Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
https://hg.mozilla.org/integration/autoland/rev/620e4b9d8b61
avoid initializing GeckoMediaPluginServiceParent during shutdown, r=alwu,media-playback-reviewers.
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Backed out for causing mochitest failures on GeckoChildProcessHost.cpp

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 98 Branch → ---
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7747fe78d924
Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
https://hg.mozilla.org/integration/autoland/rev/c0e00d17a9d9
avoid initializing GeckoMediaPluginServiceParent during shutdown, r=alwu,media-playback-reviewers.

(In reply to Cristian Tuns from comment #9)

Backed out for causing mochitest failures on GeckoChildProcessHost.cpp

  • Failure line: SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/ipc/glue/GeckoChildProcessHost.cpp:867:23 in SetAlreadyDead

Sorry, that's totally bug 1750044, where we discussed this and decided I could land with a skip-if on the test... but it turns out I put it on the wrong line :-(.

Flags: needinfo?(florian)
Component: Audio/Video → Audio/Video: GMP
Status: REOPENED → RESOLVED
Closed: 10 days ago9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.