1745589 - Header bar background black on eOS 5.1.7

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: Screenshot from 2021-12-11 16.05.50.png

With bug 1744496 the header bar background is now black on elementary OS 5.1.7 Hera (that's GTK 3.22.30 on Kernel 4.15.0-163 by Ubuntu 18.04.6 LTS). The corners appear to be transparent. The screenshot is with the default Firefox theme, so the header bar should have the default eOS gradient. This is also apparent by the text color on tabs, not shown in the screenshot.

When the window is maximized, the header bar has the expected background color.

Regression window by mozregression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=00d3e0f20e2c8798f4ca39d2d84952222b1fdd5b&tochange=5ff985e01c654ce10096df52bfc2bb1b3af7b0c1

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Thanks for filing! Do you happen to know which revision of the elementary GTK stylesheets is that version using?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Will try to poke either way though.

Comment 3

[Martin Giger [:freaktechnik]]

elementary-theme has version 5.4.2+r997+pkg327~ubuntu5.1.2.1 (https://ppa.launchpad.net/elementary-os/stable/ubuntu/pool/main/e/elementary-theme/elementary-theme_5.4.2+r997+pkg327~ubuntu5.1.2.1_all.deb) This is presumably based on https://github.com/elementary/stylesheet/tree/7902bdb8a4c49128870ab785f6fe3d035e1edfee

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1745589 - Ensure we also draw headerbar parent if the headerbar has no background. r=stransky

Even if it has a radius. This can happen in older ElementaryOS themes...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/118ea02dc6f3
Ensure we also draw headerbar parent if the headerbar has no background. r=stransky

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1744496

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/118ea02dc6f3

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/118ea02dc6f3