1745610 - Pipewire: Render mouse cursor in Firefox screencast

Status: RESOLVED DUPLICATE of bug 1816431

(Core :: WebRTC, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1672944#c29

It seems that libwebrtc used by firefox,

https://github.com/mozilla/gecko-dev/blob/master/third_party/libwebrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc

is outdated and does not contain the detection of cursor mode. The new version from google, as pointed out by Dan Shick

https://webrtc.googlesource.com/src/+/refs/heads/main/modules/desktop_capture/linux/base_capturer_pipewire.cc#1035

does contain the detection. So I hope the mozilla developer can upgrade their libwebrtc.

Comment 2

[Byron Campen [:bwc]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #0)

This link is not publicly accessable:

https://webrtc.googlesource.com/src/+/refs/heads/main/modules/desktop_capture/linux/base_capturer_pipewire.cc#1035

I can find this, and we do not have this code presently:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc;l=819-833?q=base_capturer_pipewire.cc&ss=chromium

I'm guessing we'll get to this when we get caught up?

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Byron, what are your estimates on cherry-pick-ability?

Comment 4

[Andreas Pehrson [:pehrsons]]

Lots of broken links here. It moved to a subdir. This might be a better permalink? https://webrtc.googlesource.com/src/+/73bfa48/modules/desktop_capture/linux/wayland/base_capturer_pipewire.cc#818

Should hopefully not be too bad cherry-picking this. I assume the API hasn't changed much.

Maybe we could try jumping to 5644e55 which is right before the files moved.

Comment 5

[Andreas Pehrson [:pehrsons]]

I did a simple copy of the files in 5644e55 into our tree and adapted a bit. Blocked on libepoxy headers pretty early.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Fedora downstream patch

There's a downstream patch used by Fedora/Firefox to backport WebRTC changes.