Warn users when setting an ill advised custom keyboard shortcut for addons
Categories
(Toolkit :: Add-ons Manager, enhancement, P5)
Tracking
()
People
(Reporter: original.roju, Unassigned)
References
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0
Steps to reproduce:
Firefox will let you set a custom keyboard shortcut for extensions that might not work in all cases. See #1743946, where a user wanted to set alt-q as a shortcut on MacOS, but found it didn't work if a text area was focused.
- Install an addon that provides keyboard shortcuts
- Navigate to about:addons
- In the "Extensions" view, open "Manage Extension Shortcuts"
- Set "alt-q" as a shortcut
- Navigate to a page with a text area, focus it, and try to use alt-q
Actual results:
- Firefox will set this as the shortcut without a warning
- When you try to use it with a text area focused, instead you'll type "œ"
Expected results:
- Firefox warns you that the shortcut might not work in all cases
|
||
Comment 1•2 years ago
|
||
| good-bot | ||
The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 2•2 years ago
|
||
This could be implemented at
https://searchfox.org/mozilla-central/rev/4646b826a25d3825cf209db890862b45fa09ffc3/toolkit/mozapps/extensions/content/shortcuts.js
The definition of "valid shortcuts" are defined here:
https://searchfox.org/mozilla-central/rev/4646b826a25d3825cf209db890862b45fa09ffc3/toolkit/modules/ShortcutUtils.jsm
Patches are welcome; to get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp
Description
•