Closed Bug 1745673 Opened 2 years ago Closed 2 years ago

Save To Pocket button should act as a toggle

Categories

(Toolkit :: Reader Mode, enhancement)

Product:
Toolkit
Component:
Reader Mode
Platform:
Desktop
All
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mathew.hodson, Assigned: burnha42)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
48 bytes, text/x-phabricator-request
Details | Review

In Reader mode, clicking on the Save To Pocket button should act as a toggle. If the Pocket door-hanger is open, clicking the button should close it.

That would be more consistent behaviour, and similar to the change that was made to another dialog in bug 1733427.

Component: Untriaged → Reader Mode
Product: Firefox → Toolkit
Assignee: nobody → burnha42
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259758 - Attachment is obsolete: true
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Attachment #9259245 - Attachment description: WIP: Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley → Bug 1745673 - Reader mode save to pocket button toggle. r=niklas,mtigley
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a411ca63f913
Reader mode save to pocket button toggle. r=niklas,mtigley

https://hg.mozilla.org/mozilla-central/rev/a411ca63f913

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

Verified on Firefox 100.0b5 for Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: