1745734 - Insecure connection icon is barely visible on http website login form with dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screenshot 2021-12-13 at 16.22.53.png

Affected versions

• 97.0a1 (20211213093143)
• 96.0b4 (20211212185725)
• 95.0 (20211129150630)
• 91.4.0esr (20211126104708)

Affected platforms

• macOS 11.6

Preconditions

• dark theme enabled

Steps to reproduce

1. Open Firefox and http://jsbin.testim.io/soviruvalo/1/edit?html,output.
2. Click on the username/ password form and observe the insecure icon.

Expected result

• The icon is visible.

Actual result

• The lock icon is barely visible.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8b54a4990d7e778b82909a871e92031a4bc649d&tochange=4b3932f9c4f5d9572da2f0232375474133191500
  Potential regressor: bug 1715619.

Notes

• Screenshot attached.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Not sure if this is the right component for this bug, but it isn't widget/cocoa.

Comment 2

[Kestrel]

I also see this on Windows and Linux with insecure logins since the warning changed to dark theme.

Regression window (Windows):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ef7b596bb385f46280eb1492009bf8fb541e17db&tochange=3cf700ab977a298e19a00f1ec66d14939766955b

Possibly regressed by Bug 1734367.

Regression window (Linux):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=578715b6d3fcb21c0b61996347260ef9b119d0d2&tochange=8508c35e49793fbe402ad2a706a57fabd1c2b0c4

Possibly regressed by Bug 1707872.

Comment 3

[Kestrel]

Attachment: Insecure padlock icon contrast issue

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1745734 - Fix styling of insecure warning. r=#theme

--grey-60 doesn't exist in browser chrome, so color behaves as
currentColor, and fill as initial which is black.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a09f7c430e
Fix styling of insecure warning. r=desktop-theme-reviewers,dao

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/e2a09f7c430e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I think we have been living with this for long, and this is hopefully a somewhat uncommon thing to run into.

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build following the STR from Comment 0.
Verified as fixed on the latest Nightly 136.0a1 (20250109183505) and latest Beta 135.0B2 (20250108092002) using Windows 11, Ubuntu 22.04 and macOS 11.