1745745 - Invitations Manager seems broken, link to open does not show most times.

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Lasana Murray]

I received an invitation and the link in the status bar to open the invitation manager did not show up. I opened the event and saved it without sending a response and it did not show up. I let the server add the event and it still did not show up.

I'm not sure how this is spec'd to work but seems like something is wrong.

Comment 1

[Magnus Melin [:mkmelin]]

I'm not sure exactly how it works, but seems to be working like it always has for me. (Used it today)

Comment 2

[Lasana Murray]

I'm unable to make the link appear on daily. I wonder if it has something to do with the server processing the invitations once I open the email?

Comment 3

[Lasana Murray]

Ok. Seems like this is supposed to show when items are found on the calendar that start from the present date + 1 year that still need action:
https://searchfox.org/comm-central/rev/8ff729816194e4735ac196a918e6f9d167e5d211/calendar/base/content/calendar-invitations-manager.js#278

and

https://searchfox.org/comm-central/rev/8ff729816194e4735ac196a918e6f9d167e5d211/calendar/base/content/calendar-invitations-manager.js#76

That does make sense but I imagine this dialog would be more useful if it could be used to review all invitations. Currently I use search to review previous invitations.

Comment 4

[Magnus Melin [:mkmelin]]

Why would you review previous invitations, outside of debugging?
I think what it does makes sense, since you'd really not want to encourage anyone sending RSVPs to events from the past.

Comment 5

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #4)

Why would you review previous invitations, outside of debugging?

I often do not respond to invites immediately and have to search the inbox to find them. Sometimes I need to review how an event has changed as well (times etc.). There is also the probability of accidentally deleting the email making doing this harder. When people ask me "did you get the invite?" it would be nice to able to click a button and answer that quickly.

I think what it does makes sense, since you'd really not want to encourage anyone sending RSVPs to events from the past.

I don't think that's an issue. We check that an event has already been responded to before presenting the actions to the user.

Comment 6

[Magnus Melin [:mkmelin]]

(In reply to Lasana Murray from comment #5)

I don't think that's an issue. We check that an even has already been responded to before presenting the actions to the user.

People come back from a month holiday and have 50 events from the past waiting. With what you propose, they would almost have to accept all to get their view decent again. But nobody cares about those old events anymore...

Comment 7

[Magnus Melin [:mkmelin]]

(In reply to Lasana Murray from comment #5)

Sometimes I need to review how an event has changed as well (times etc.).

Unfortunately our code doesn't do that well. I believe if the events were processed, no matter if you responded or not, you'll see changes from what is in our db, not from what it was at the time... which is very confusing.

Comment 8

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #6)

(In reply to Lasana Murray from comment #5)

I don't think that's an issue. We check that an even has already been responded to before presenting the actions to the user.

People come back from a month holiday and have 50 events from the past waiting. With what you propose, they would almost have to accept all to get their view decent again.

No. Good UI will only show the ones that are still relevant, providing an option to see the ones that have gone since. Currently the panel is designed to only show upcoming events in any case.

But nobody cares about those old events anymore...

You can't say that. For people who frequently attend or organize events, especially events that recur, it is likely they may need to review past ones from time to time.

Comment 9

[Lasana Murray]

Ok, I understand what this is now. This is not really concerned with invitations in the inbox per say, it's just pulling invitations from the calendars where the attendee partstat is "NEEDS-ACTION". Those tend to more or less the ones automatically added by the server (I don't think you set an event to "NEEDS-ACTION" from the UI). If you disable the auto add feature on the server and open an invitation email, but take no action, it will not trigger the invitations manager link. This is a peculiar piece of UI and I don't think they way it works now is intuitive.

Nevertheless, I encountered a bug caused by bug 1693873 that prevents the link from showing completely so I'll address that here. We should provide a more robust interface for keeping track of invitations.

Comment 10

[Lasana Murray]

Attachment: Bug 1745745 - Close item stream after reading all invitations. r=darktrojan

Comment 11

[Magnus Melin [:mkmelin]]

On trunk I'm getting a "TypeError: 'enqueue' may only be called on a stream in the 'readable' state. CalReadableStreamFactory.jsm:175:24" error on startup. Is this about that?

Comment 12

[Magnus Melin [:mkmelin]]

Also got "ReferenceError: can't access lexical declaration 'clearPending' before initialization calCachedCalendar.js:285:7"

Comment 13

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #11)

On trunk I'm getting a "TypeError: 'enqueue' may only be called on a stream in the 'readable' state. CalReadableStreamFactory.jsm:175:24" error on startup. Is this about that?

Are you seeing that consistently?

Also got "ReferenceError: can't access lexical declaration 'clearPending' before initialization calCachedCalendar.js:285:7"

That looks like a bug, I'll file one for that.

Comment 14

[Magnus Melin [:mkmelin]]

Are you seeing that consistently?

Doesn't seem so.

Comment 15

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #14)

Are you seeing that consistently?

Doesn't seem so.

That's a strange one. I'm not sure if this would address that yet. I'll have to monitor that.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/76c187cd0854
Close item stream after reading all invitations. r=darktrojan