1745818 - Treat host permissions as optional in MV3 manifest

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Tomislav Jovanovic :zombie]

• ⬜ When a manifest v3 extension is installed, don’t add host_permissions and content_script match patterns to allowedOrigins.
• ⬜ Remove host permissions from the initial install prompt.
• ⬜ Implement granted_host_permissions manifest key to revert to previous behavior for testing and privileged extensions.
• ⬜ Implement a pref for manifest v2 extensions to behave the same, default to false.
• ⬜ Adjust our existing mv3 tests to work with these changes.
• ⬜ Write new tests for all of the above.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1745818 - Treat host permissions as optional in mv3, r=robwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53b7b2117588
Treat host permissions as optional in mv3, r=robwu

Comment 3

[Iulian Moraru]

Backed out for causing mochitest failures on test_ext_scripting_executeScript.html.

Push with failures

Failure log

Backout link

[task 2022-03-12T16:27:56.643Z] 16:27:56     INFO -  TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript.html | expected 1 tab - Expected: 1, Actual: 1
[task 2022-03-12T16:27:56.643Z] 16:27:56     INFO -  Buffered messages finished
[task 2022-03-12T16:27:56.644Z] 16:27:56  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript.html | Test timed out. -
[task 2022-03-12T16:27:56.644Z] 16:27:56  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript.html | Extension left running at test shutdown
[task 2022-03-12T16:27:56.644Z] 16:27:56     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-03-12T16:27:56.644Z] 16:27:56     INFO -      ExtensionTestUtils.loadExtension/<@SimpleTest/ExtensionTestUtils.js:129:18
[task 2022-03-12T16:27:56.644Z] 16:27:56     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1487:13
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1501:3
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      killTest@SimpleTest/TestRunner.js:194:22
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      async*delayedKillTest@SimpleTest/TestRunner.js:231:17
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:229:17
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.645Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.646Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:242:15
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      TestRunner.runTests/<@SimpleTest/TestRunner.js:521:16
[task 2022-03-12T16:27:56.647Z] 16:27:56     INFO -      Async*TestRunner.runTests@SimpleTest/TestRunner.js:508:48
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -      RunSet.runtests@SimpleTest/setup.js:232:14
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -      RunSet.runall@SimpleTest/setup.js:211:12
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -      hookupTests@SimpleTest/setup.js:308:12
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -  parseTestManifest@http://mochi.test:8888/manifestLibrary.js:51:13
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -  getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:64:28
[task 2022-03-12T16:27:56.648Z] 16:27:56     INFO -  EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:60:3
[task 2022-03-12T16:27:56.649Z] 16:27:56     INFO -      hookup@SimpleTest/setup.js:284:20
[task 2022-03-12T16:27:56.649Z] 16:27:56     INFO -  EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&logFile=%2Fdata%2Flocal%2Ftmp%2Ftest_root%2Flogs%2Fmochitest.log&fileLevel=INFO&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fdata%2Flocal%2Ftmp%2Ftest_root:11:1
[task 2022-03-12T16:27:56.649Z] 16:27:56     INFO -  TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript.html | took 318734ms
[task 2022-03-12T16:27:56.649Z] 16:27:56  WARNING -  TEST-UNEXPECTED-FAIL | /tests/toolkit/components/extensions/test/mochitest/test_ext_scripting_executeScript.html logged result after SimpleTest.finish(): Extension left running at test shutdown
[task 2022-03-12T16:27:56.649Z] 16:27:56     INFO -  TEST-START | toolkit/components/extensions/test/mochitest/test_ext_scripting_insertCSS.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/669b00e88416
Treat host permissions as optional in mv3, r=robwu

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/669b00e88416