Closed Bug 1745887 Opened 2 years ago Closed 2 years ago

Flush stdout immediately after printing test name in jsapi-test

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

jsapi-test prints the test name before running the test, but it uses stdout that has buffering,
and if the test crashes, the test name might not appear in the log.

bug 1745527 log shows that the test name isn't printed before the crash.

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/93cbd375f4b5
Flush stdout immediately after printing test name in jsapi-test. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

Hello, Perfherder has found these improvements. Could you please take a look and tell me if they are from this patch?

== Change summary for alert #32780 (as of Fri, 17 Dec 2021 22:04:05 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
6% build times linux64-shippable nightly taskcluster-m5d.4xlarge 2,544.45 -> 2,391.56
6% build times linux64-shippable nightly taskcluster-m5dn.4xlarge 2,567.25 -> 2,414.67
6% build times linux64-shippable nightly taskcluster-m5n.4xlarge 2,609.80 -> 2,458.19
5% build times linux64-shippable nightly taskcluster-m5.4xlarge 2,600.63 -> 2,461.90

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32780

It should be from different patch.
This doesn't reduce any of build time or C++ test runtime.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: