Closed Bug 1745958 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32033 - Test for inline blocks with children with orthogonal writing modes and margins

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32033 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32033
Details from upstream follow.

Sergio Villar Senin <svillar@igalia.com> wrote:

Test for inline blocks with children with orthogonal writing modes and margins

This was created after this WebKit bug.

In order to compute the shrink to fit inline size of an inline block we must compute first the inline sizes of our children. This includes margins as well. The bug in WebKit was that it was always using the inline (from the child POV) margins of its children. That works if the children are parallel to the parent, but if any of them is orthogonal then we should use the margins in the block direction of the child (which correspond to the inline direction of the parent).

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0935460683f7
[wpt PR 32033] - Test for inline blocks with children with orthogonal writing modes and margins, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dd927340adc7
[wpt PR 32033] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0935460683f7
https://hg.mozilla.org/mozilla-central/rev/dd927340adc7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.