Closed Bug 1746014 Opened 2 years ago Closed 2 years ago

Save to Pocket save panel refresh

Categories

(Firefox :: Pocket, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
100 Branch
Tracking Status
firefox100 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1746013
No longer depends on: 1746013
Blocks: 1746020
Priority: -- → P1
Assignee: nobody → sdowne
Assignee: sdowne → nobody
Depends on: 1752409
Summary: Save to Pocket save panel refresh → [meta] Save to Pocket Refresh
Summary: [meta] Save to Pocket Refresh → Save to Pocket save panel refresh
No longer depends on: 1753283
Blocks: 1753304
Assignee: nobody → sdowne

To test:

  1. Set extensions.pocket.refresh.layout.enabled to true
  2. Log in to Pocket.
  3. Try to save a Pocket story.

Expected: Should see a new Saved panel.

  1. Click remove.

Expected: should remove the Pocket story.

  1. Set extensions.pocket.showHome to false.
  2. Restart
  3. Try to save newtab to Pocket.

Expected: Should see an error message.

  1. Using the mutlti process debugger, set the option "Disable Popup auto hide" to true.
  2. Open 2 tabs, and move them to 2 windows, side by side.
  3. Open a Pocket story in one, and your Pocket list on getpocket.com in another.
  4. Click the save to Pocket button in the Pocket story window.
  5. Log out of Pocket in the other window, while keeping the Pocket panel open because of "Disable Popup auto hide".
  6. In the Pocket story window, now click "remove"

Expected: Should see an error message about valid access token, because you are no longer logged in when you tried to remove it.

Attachment #9264291 - Attachment description: WIP: Bug 1746014 - Pocket button refresh, saved panel. → Bug 1746014 - Pocket button refresh, saved panel.
Blocks: 1760899
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/723695a8167f
Pocket button refresh, saved panel. r=gvn,flod
Attachment #9264291 - Attachment description: Bug 1746014 - Pocket button refresh, saved panel. → WIP: Bug 1746014 - Pocket button refresh, saved panel.
Attachment #9264291 - Attachment description: WIP: Bug 1746014 - Pocket button refresh, saved panel. → Bug 1746014 - Pocket button refresh, saved panel.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Attachment #9264291 - Attachment description: Bug 1746014 - Pocket button refresh, saved panel. → WIP: Bug 1746014 - Pocket button refresh, saved panel.
Attachment #9264291 - Attachment description: WIP: Bug 1746014 - Pocket button refresh, saved panel. → Bug 1746014 - Pocket button refresh, saved panel.
Attachment #9264291 - Attachment description: Bug 1746014 - Pocket button refresh, saved panel. → Bug 1746014 - Pocket button refresh, saved panel. r=gvn,flod
Flags: qe-verify+

This feature is implemented on Firefox 100.0(20220428192727) . Tested on macOS 11, Win10 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: