1746027 - Save to Pocket refresh prefs and nimbus implementation

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement)

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1746027 - Save to Pocket refresh prefs and Nimbus implementation

Comment 2

[Scott [:thecount] Downe]

To test:

You'll need to open and verify each panel, then flip some prefs, and verify each panel again.

To open a panel and verify their query params, do this:

1. Enable "Disable Popup Auto-Hide" from multiprocess toolbox.
2. Click the save to Pocket button.
3. Because "Disable Popup Auto-Hide" is set, the panel should stay open, allowing you to inspect it. You can do this with the "Pick an element from the page" button in the top left of the multiprocess toolbox.
4. in the inspector, find the url in the browser element, and check the query params.

You want to do steps 1-4 for each panel, signup, saved, and home (click the Pocket button from a newtab to get the home panel).
You need to toggle "Disable Popup Auto-Hide" on and off to open and close panels as needed.

Go about about:config and flip extensions.pocket.refresh.layout.enabled and extensions.pocket.refresh.emailButton.enabled to true
Now test each panel with the prefs flipped to true.

Expected:
Signup panel should have search params: utmCampaign, utmSource, emailButton, layoutRefresh, pockethost, and locale
Home panel should have search params: layoutRefresh, pockethost, and locale
Saved panel should have search params: premiumStatus, fxasignedin, layoutRefresh, pockethost, and locale
emailButton, layoutRefresh should flip based on the prefs. No other search params should be changing from what's on master.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e481b6eb9a48
Save to Pocket refresh prefs and Nimbus implementation r=gvn,andreio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e481b6eb9a48