Closed Bug 1746028 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32056 - Allow empty CSS custom properties values.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32056 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32056
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Allow empty CSS custom properties values.

This used to be a parse error, now it's simply allowed.

R=andruud@chromium.org

Bug: 1220149
Change-Id: I61e10aab1c155c6cfcab3ad19c3934382881f448
Reviewed-on: https://chromium-review.googlesource.com/3338992
WPT-Export-Revision: 5d40cf1da1282ce09c14b9a5fc60a74f95d652b6

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 73 subtests

Status Summary

Firefox

OK : 1
PASS: 71
FAIL: 2

Chrome

OK : 1
PASS: 44
FAIL: 29

Safari

OK : 1
PASS: 56
FAIL: 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-variables/variable-definition.html
CSSOM.setProperty with space 1: FAIL (Chrome: FAIL, Safari: FAIL)
CSSOM.setProperty with space 2: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4aa30b28fff
[wpt PR 32056] - Allow empty CSS custom properties values., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.