Closed Bug 1746081 Opened 5 months ago Closed 4 months ago

Use listbox rather than tree in FilterListDialog

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.94
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.11)

Attachments

(1 file, 1 obsolete file)

At the moment we use a tree for displaying filter rules in the FilterListDialog but that makes it more difficult to implement search functionality so let's switch to using a listbox like TB does.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: blocks future enhancements
Testing completed (on m-c, etc.): 2.53.11
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9255352 - Flags: review?(frgrahl)
Attachment #9255352 - Flags: approval-comm-release?
Attachment #9255352 - Flags: approval-comm-esr60?

Removed unused function.

Attachment #9255352 - Attachment is obsolete: true
Attachment #9255352 - Flags: review?(frgrahl)
Attachment #9255352 - Flags: approval-comm-release?
Attachment #9255352 - Flags: approval-comm-esr60?
Attachment #9255353 - Flags: review?(frgrahl)
Attachment #9255353 - Flags: approval-comm-release?
Attachment #9255353 - Flags: approval-comm-esr60?

Comment on attachment 9255353 [details] [diff] [review]
1746081-fld-tree-to-list-v1_1-25311.patch

suite/mailnews/content/FilterListDialog.js

// Calling getFilterList will detect any errors in rules.dat,
// backup the file, and alert the user

  • gFilterTreeView.filterList = msgFolder.getEditableFilterList(gFilterListMsgWindow);
  • gCurrentFilterList = msgFolder.getEditableFilterList(gFilterListMsgWindow);
  • rebuildFilterList();

Comparing to TB it seems the comment is wrong. Change to

// Calling getEditableFilterList will detect any errors in msgFilterRules.dat,
// backup the file, and alert the user.

while we are at it?

  •  let size = (enabledCell.clientWidth - 28) / 2;
    
  •  enabledCell.style.paddingLeft = size.toString() + "px";
    

This looks a bit "ugly" and TB does not have it. Didn't try without. does it fix a specfic visual glitch?

Otherwise LGTM. r/a+ with these two items commented on or changed.

Attachment #9255353 - Flags: review?(frgrahl)
Attachment #9255353 - Flags: review+
Attachment #9255353 - Flags: approval-comm-release?
Attachment #9255353 - Flags: approval-comm-release+
Attachment #9255353 - Flags: approval-comm-esr60?
Attachment #9255353 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/aa09e7678bc9
Use listbox rather than tree in FilterListDialog. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.11
Target Milestone: --- → seamonkey 2.94
You need to log in before you can comment on or make changes to this bug.