1746081 - Use listbox rather than tree in FilterListDialog

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Ian Neal]

At the moment we use a tree for displaying filter rules in the FilterListDialog but that makes it more difficult to implement search functionality so let's switch to using a listbox like TB does.

Comment 1

[Ian Neal]

Attachment: 1746081-fld-tree-to-list-25311.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: blocks future enhancements
Testing completed (on m-c, etc.): 2.53.11
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1746081-fld-tree-to-list-v1_1-25311.patch

Removed unused function.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9255353 [details] [diff] [review]
1746081-fld-tree-to-list-v1_1-25311.patch

suite/mailnews/content/FilterListDialog.js

// Calling getFilterList will detect any errors in rules.dat,
// backup the file, and alert the user

• gFilterTreeView.filterList = msgFolder.getEditableFilterList(gFilterListMsgWindow);

• gCurrentFilterList = msgFolder.getEditableFilterList(gFilterListMsgWindow);
• rebuildFilterList();

Comparing to TB it seems the comment is wrong. Change to

// Calling getEditableFilterList will detect any errors in msgFilterRules.dat,
// backup the file, and alert the user.

while we are at it?

•  let size = (enabledCell.clientWidth - 28) / 2;
  

•  enabledCell.style.paddingLeft = size.toString() + "px";
  

This looks a bit "ugly" and TB does not have it. Didn't try without. does it fix a specfic visual glitch?

Otherwise LGTM. r/a+ with these two items commented on or changed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aa09e7678bc9
Use listbox rather than tree in FilterListDialog. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/643377d27ca7de70f6bb6305f90acae2510fe9bc
Use listbox rather than tree in FilterListDialog. r=frg a=frg