1746205 - H264 profile-level-id needs to be set in SdpVideoFormat::parameters

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Byron Campen [:bwc]]

We are using the profile-level-id negotiated in JSEP to set VideoCodecConfigH264::profile_level_id, which is in turn used to set members in VideoCodecConfig, but nothing is ever actually using those members. This means we just end up using the default in ParseSdpProfileLevelId. This happens to match what we negotiate by default, but when we negotiate something different the wrong thing is configured.

We need to:

1. Set SdpVideoFormat::parameters appropriately, and
2. Probably change the way we are storing the profile-level-id in VideoCodecConfig (since SdpVideoFormat::parameters will take a string, and we are currently decomposing into integers)

I should note that we have never set SdpVideoFormat::parameters, and mozilla-release does not use this field in the same way as mozilla-central and beta. I am not sure how this was supposed to be configured in the past, but I suppose that is moot.

Marking this as P3/S3, since it has been this way for a long time (possibly since we first supported H264?), and nobody has complained. This is probably a simple fix, so might be a beta uplift candidate, although there is the potential to break things that expect us to always use constrained baseline level 3.1 regardless of what was negotiated. My feeling on this is fix on nightly and let it ride.