Closed
Bug 1746316
Opened 3 years ago
Closed 3 years ago
Minor locking issue with security/manager DataStorage
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
97 Branch
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Keywords: sec-audit, sec-low, Whiteboard: [post-critsmash-triage][adv-main97+r])
Attachments
(1 file)
Found a minor locking issue in DataStorage in security/manager/ssl -- it doesn't lock before accessing under-lock fields for SizeOfIncludingThis.
Also added a few thread-safety asserts
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
|
||
Updated•3 years ago
|
Group: core-security → crypto-core-security
|
||
Comment 2•3 years ago
|
||
Lock when collecting SizeOfIncludingThis r=keeler
https://hg.mozilla.org/integration/autoland/rev/3670d13b6cb0a0525a614e868d089f6b1010bdd9
https://hg.mozilla.org/mozilla-central/rev/3670d13b6cb0
Group: crypto-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
|
||
Comment 3•3 years ago
|
||
Per IRL discussion with Randell, this is mostly cleanup and not likely affecting us in the wild in a way which would make us want to backport.
|
||
Updated•3 years ago
|
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
|
||
Updated•3 years ago
|
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main97+r]
|
|
||
Updated•2 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•