Closed Bug 1746347 Opened 10 months ago Closed 9 months ago

Update profiler media preset thread-set

Categories

(Core :: Gecko Profiler, task, P2)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Some old webrtc threads no longer exist, while the "WebrtcCallThread" single-thread thread pool was added late in bug 1654112.

If you are touching the (long) list of threads of the media preset, you might be interested in knowning that the thread filter done by the profiler is a case insensitve substring search: https://searchfox.org/mozilla-central/rev/b80b92e2e10299ab405bdc4eb5109e9e23e25160/mozglue/baseprofiler/core/platform.cpp#656,677-678

So I think the current list of threads can be simplified a lot and made more future proof by including Audio,Media,Webrtc

Also, when I used the Media preset yesterday to file bug 1746156, I wondered why it didn't include the ipcmessages feature, as the Media pipeline involves activity on multiple processes (at least the content process + the RDD process, and sometimes the GMP process) and I think seeing the IPCs in profiles would be valuable.

Flags: needinfo?(apehrson)
See Also: → 1746361

Thanks, I think I have managed to capture this. The list is simpler though not remarkably shorter.

Flags: needinfo?(apehrson)
Blocks: 1743694
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f78e794a9c2f
Simplify the profiler's media preset's thread-set. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/6f9e800877a6
Add ipcmessages feature to the profiler's media preset. r=canaltinova

The ipcmessages feature was caught by a devtools test. I've updated that and it now passes locally.

Flags: needinfo?(apehrson)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0dd2a0923bc5
Simplify the profiler's media preset's thread-set. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/7bd87eee837f
Add ipcmessages feature to the profiler's media preset. r=canaltinova
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.