1746486 - Client shadows should be used in Cinnamon.

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Webster]

Attachment: cinnamon-csd.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

1. Launch firefox in Cinnamon, using Mint-Y gtk3 theme (or potentially some other with significantly rounded window header corners).
2. Application menu-> More tools -> Customize toolbar, Uncheck "Title bar"

Actual results:

Observe sharp corner artifact in addition to rounded corners.

Expected results:

Rounded corners, matching other gtk client-decorated apps..

Comment 1

[Michael Webster]

Attachment: Bug 1746486 - Cinnamon should use GTK_DECORATION_CLIENT r?stransky

Cinnamon supports _GTK_FRAME_EXTENTS.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Can you test latest nighty?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries

It's supposed to work there, it's Bug 1509931.

Comment 3

[Michael Webster]

Same result - my issue looks slightly different than that (and I'm on x11, not wayland). I should have noted I had tested this on the bookmarks/beta branch (my user agent is from my system version).

I notice we still end up with a frame and content window here (using wininfo to check) - it could be causing confusion. I haven't had time to dig into the 'why' any further yet. We've probably had this issue for a while, but we just recently changed our theme to have rounded titlebar corners and finally noticed it.

I tested on gnome-shell/x11 3.36.9 using the same theme, and it doesn't seem affected, though there are significant differences in how decorations are handled between muffin and mutter). But for the purposes of emulating a 'real' client-decorated GtkWindow, we should have _GTK_FRAME_EXTENTS set.

Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4f54b8aab64
Cinnamon should use GTK_DECORATION_CLIENT r=stransky

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e4f54b8aab64

Comment 6

[Michael Webster]

Thanks a lot!

Is there any chance this can make it in 96 stable? If not I understand - I realize it's fairly late in the beta cycle - but this is a trivial change and it's a pretty visible issue for Cinnamon users.

Thanks again

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9255784 [details]
Bug 1746486 - Cinnamon should use GTK_DECORATION_CLIENT r?stransky

Beta/Release Uplift Approval Request

• User impact if declined: Cinnamon users will see wrong titlebar corners when system titlebar is disabled.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial switch of titlebar style, already testes on Wayland/KDE and other environments.
• String changes made/needed:

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9255784 [details]
Bug 1746486 - Cinnamon should use GTK_DECORATION_CLIENT r?stransky

Approved for 96.0b9

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6dba07e5de5a

Comment 10

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce this issue on 96.0b7(BuildID:20211219185855) with Linux Mint 20.2 Cinnamon.

Confirming this issue as verified fixed on 96.0b9(BuildID:20211223202418) and 97.0a1(BuildID:20211226213620) on Linux Mint 20.2 Cinnamon.

Comment 11

[Michael Webster]

Thanks for squeezing this in!